You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Alexandre Rafalovitch <ar...@gmail.com> on 2015/02/05 15:51:51 UTC

Interesting resource for Unix shell script cleanup

Hi,

Just saw a link to http://www.shellcheck.net/ .

I run Solr start script and it picked up a couple of interesting
issues around variable escaping and deprecated shell commands.

Is that something that's worth making JIRA about?

Regards,
   Alex.
----
Sign up for my Solr resources newsletter at http://www.solr-start.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: Interesting resource for Unix shell script cleanup

Posted by "david.w.smiley@gmail.com" <da...@gmail.com>.
Cool!

~ David Smiley
Freelance Apache Lucene/Solr Search Consultant/Developer
http://www.linkedin.com/in/davidwsmiley

On Thu, Feb 5, 2015 at 10:25 AM, Steve Rowe <sa...@gmail.com> wrote:

> > On Feb 5, 2015, at 9:51 AM, Alexandre Rafalovitch <ar...@gmail.com>
> wrote:
> >
> > Hi,
> >
> > Just saw a link to http://www.shellcheck.net/ .
> >
> > I run Solr start script and it picked up a couple of interesting
> > issues around variable escaping and deprecated shell commands.
> >
> > Is that something that's worth making JIRA about?
> >
>
> +1
>
> Steve
> http://www.lucidworks.com
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

Re: Interesting resource for Unix shell script cleanup

Posted by Steve Rowe <sa...@gmail.com>.
> On Feb 5, 2015, at 9:51 AM, Alexandre Rafalovitch <ar...@gmail.com> wrote:
> 
> Hi,
> 
> Just saw a link to http://www.shellcheck.net/ .
> 
> I run Solr start script and it picked up a couple of interesting
> issues around variable escaping and deprecated shell commands.
> 
> Is that something that's worth making JIRA about?
> 

+1

Steve
http://www.lucidworks.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: Interesting resource for Unix shell script cleanup

Posted by Erik Hatcher <er...@gmail.com>.
Neat tool.  I just pasted bin/post in there and it pointed out some things to update (though nothing glaringly wrong mentioned, thankfully).

By all means, please make JIRAs for any findings/patches.  Maybe this is a tool we could even incorporate into our tests in some way?

	Erik


> On Feb 5, 2015, at 9:51 AM, Alexandre Rafalovitch <ar...@gmail.com> wrote:
> 
> Hi,
> 
> Just saw a link to http://www.shellcheck.net/ .
> 
> I run Solr start script and it picked up a couple of interesting
> issues around variable escaping and deprecated shell commands.
> 
> Is that something that's worth making JIRA about?
> 
> Regards,
>   Alex.
> ----
> Sign up for my Solr resources newsletter at http://www.solr-start.com/
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org