You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "stefan-egli (via GitHub)" <gi...@apache.org> on 2024/03/26 17:03:24 UTC
[PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]
stefan-egli opened a new pull request, #1383:
URL: https://github.com/apache/jackrabbit-oak/pull/1383
… and deleted properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1383:
URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1541043816
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1007,6 +1008,10 @@ public void collectGarbage(final NodeDocument doc, final GCPhases phases) {
// here the node is not orphaned which means that we can reach the node from root
collectDeletedProperties(doc, phases, op, traversedState);
switch(revisionDetailedGcType) {
+ case NO_OLD_PROP_REV_GC : {
+ // this mode does neither unusedproprev, nor unmergedBC
Review Comment:
this would log it quite frequently no? - what about doing it in the constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on PR #1383:
URL: https://github.com/apache/jackrabbit-oak/pull/1383#issuecomment-2022597351
PR approved with a minor review comment that can be handled later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on code in PR #1383:
URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1540970470
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1007,6 +1008,10 @@ public void collectGarbage(final NodeDocument doc, final GCPhases phases) {
// here the node is not orphaned which means that we can reach the node from root
collectDeletedProperties(doc, phases, op, traversedState);
switch(revisionDetailedGcType) {
+ case NO_OLD_PROP_REV_GC : {
+ // this mode does neither unusedproprev, nor unmergedBC
Review Comment:
I would add an INFO log here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1383:
URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1541044437
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1007,6 +1008,10 @@ public void collectGarbage(final NodeDocument doc, final GCPhases phases) {
// here the node is not orphaned which means that we can reach the node from root
collectDeletedProperties(doc, phases, op, traversedState);
switch(revisionDetailedGcType) {
+ case NO_OLD_PROP_REV_GC : {
+ // this mode does neither unusedproprev, nor unmergedBC
Review Comment:
(I'll merge without and we can do it separately as you suggested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli merged PR #1383:
URL: https://github.com/apache/jackrabbit-oak/pull/1383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1383:
URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1541089542
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1007,6 +1008,10 @@ public void collectGarbage(final NodeDocument doc, final GCPhases phases) {
// here the node is not orphaned which means that we can reach the node from root
collectDeletedProperties(doc, phases, op, traversedState);
switch(revisionDetailedGcType) {
+ case NO_OLD_PROP_REV_GC : {
+ // this mode does neither unusedproprev, nor unmergedBC
Review Comment:
PS: created OAK-10727 to follow-up on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1383:
URL: https://github.com/apache/jackrabbit-oak/pull/1383#issuecomment-2022690091
> BranchCommitGCTest now fail due to using the new mode by default - requires fixing first before merging this
will be handled in OAK-10726 now (to not block this PR)
log.info we need to follow-up in a new ticket still
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1383:
URL: https://github.com/apache/jackrabbit-oak/pull/1383#issuecomment-2021043000
BranchCommitGCTest now fail due to using the new mode by default - requires fixing first before merging this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10724 : Introduce detailed gc mode that only deletes orphan nodes… [jackrabbit-oak]
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on code in PR #1383:
URL: https://github.com/apache/jackrabbit-oak/pull/1383#discussion_r1540970470
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1007,6 +1008,10 @@ public void collectGarbage(final NodeDocument doc, final GCPhases phases) {
// here the node is not orphaned which means that we can reach the node from root
collectDeletedProperties(doc, phases, op, traversedState);
switch(revisionDetailedGcType) {
+ case NO_OLD_PROP_REV_GC : {
+ // this mode does neither unusedproprev, nor unmergedBC
Review Comment:
I would add a INFO log here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org