[jira] [Resolved] (IMPALA-9761) Fix GCC 7 compilation issue: Ambiguous else warning with gtest macros

["Joe McDonnell (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe McDonnell resolved IMPALA-9761.
-----------------------------------
     Fix Version/s: Impala 4.0
    Target Version: Impala 4.0
        Resolution: Fixed

> Fix GCC 7 compilation issue: Ambiguous else warning with gtest macros
> ---------------------------------------------------------------------
>
>                 Key: IMPALA-9761
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9761
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 4.0
>            Reporter: Joe McDonnell
>            Assignee: Joe McDonnell
>            Priority: Minor
>             Fix For: Impala 4.0
>
>
> Google test uses a macro to avoid a GCC warning about dangling else conditions. It suppresses a warning for code like:
> {code:java}
> if (foo) DCHECK(condition);{code}
> [https://github.com/google/googletest/issues/1119]
> GCC 7 added new warnings and this macro no longer works. The solution is to either disable the new warning or use braces. Since using braces is easy, we should fix this by adding appropriate braces.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)