You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "upthewaterspout (GitHub)" <gi...@apache.org> on 2018/11/26 23:33:43 UTC
[GitHub] [geode] upthewaterspout opened pull request #2903:
GEODE-6074: Using a free server port in tests
GEODE-5590 and GEODE-6074 - Setting the server port to 0 to pick an
unused port. These two tests both failed in CI because port 40404 was in
use.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2903 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] upthewaterspout closed pull request #2903:
GEODE-6074: Using a free server port in tests
Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
[ pull request closed by upthewaterspout ]
[ Full content available at: https://github.com/apache/geode/pull/2903 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on issue #2903: GEODE-6074:
Using a free server port in tests
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
maybe we should build this in the GfshRule, any "start server" command should append this option to avoid port conflict. Just a thought.
[ Full content available at: https://github.com/apache/geode/pull/2903 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] upthewaterspout commented on issue #2903:
GEODE-6074: Using a free server port in tests
Posted by "upthewaterspout (GitHub)" <gi...@apache.org>.
Note - the UpgradeTestOpenJDK8 job actually passed, but it looks like concourse failed to update the status flag.
[ Full content available at: https://github.com/apache/geode/pull/2903 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org