[GitHub] [kafka] jnh5y commented on a diff in pull request #12298: KAFKA-13998 JoinGroupRequestData 'reason' can be too large

[GitBox <gi...@apache.org>]

jnh5y commented on code in PR #12298:
URL: https://github.com/apache/kafka/pull/12298#discussion_r899123618


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -478,8 +478,13 @@ boolean joinGroupIfNeeded(final Timer timer) {
 
                 resetJoinGroupFuture();
                 synchronized (AbstractCoordinator.this) {
-                    rejoinReason = String.format("rebalance failed due to '%s' (%s)", exception.getMessage(), exception.getClass().getSimpleName());
-                    rejoinNeeded = true;
+                    final String shortReason = String.format("rebalance failed due to an exception: (%s)",
+                        exception.getMessage(),

Review Comment:
   Thanks for catching that I passed in two arguments!  (That would have prevented this PR from fixing the issue...)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org