You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2024/02/26 10:03:32 UTC
[PR] ORC-1634: Fix some outdated descriptions in `Building ORC` documentation [orc]
cxzl25 opened a new pull request, #1819:
URL: https://github.com/apache/orc/pull/1819
### What changes were proposed in this pull request?
1. Require Java >=17
2. Remove broken url
### Why are the changes needed?
Some outdated descriptions in `Building ORC` documentation.
### How was this patch tested?
manual check
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1634: Fix some outdated descriptions in `Building ORC` documentation [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1819:
URL: https://github.com/apache/orc/pull/1819#issuecomment-1986519101
Now, it's announced. We can proceed this, @cxzl25 .
- https://lists.apache.org/thread/167sl5x42ll60vn4otphbzcdwdfwqcm5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1634: Fix some outdated descriptions in `Building ORC` documentation [orc]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #1819:
URL: https://github.com/apache/orc/pull/1819#discussion_r1503564090
##########
site/_docs/building.md:
##########
@@ -18,19 +18,18 @@ You'll want to install the usual set of developer tools, but at least:
* cmake
* g++ or clang++
-* java ( >= 1.8)
+* java ( >= 17)
* make
* maven ( >= 3)
For each version of Linux, please check the corresponding Dockerfile, which
is in the docker subdirectory, for the list of packages required to build ORC:
-* [CentOS 7]({{ page.dockerUrl }}/centos7/Dockerfile)
-* [Debian 10]({{ page.dockerUrl }}/debian10/Dockerfile)
* [Debian 11]({{ page.dockerUrl }}/debian11/Dockerfile)
* [Debian 12]({{ page.dockerUrl }}/debian12/Dockerfile)
* [Ubuntu 20]({{ page.dockerUrl }}/ubuntu20/Dockerfile)
* [Ubuntu 22]({{ page.dockerUrl }}/ubuntu22/Dockerfile)
+* [Ubuntu 24]({{ page.dockerUrl }}/ubuntu24/Dockerfile)
Review Comment:
Thanks. I originally wanted to link this URL https://github.com/apache/orc/blob/main/docker/os-list.txt directly in the document, but now I have completed all OS in the document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1634: Fix some outdated descriptions in `Building ORC` documentation [orc]
Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1819:
URL: https://github.com/apache/orc/pull/1819#issuecomment-1968500780
> Actually, there is a reason why we don't update this still.
>
> We publish Apache ORC website from `main` branch.
>
> So, we cannot publish this until Apache ORC 2.0 is released, @cxzl25 .
>
> Instead, let's update this PR and keep it open until Apache ORC 2.0 is released.
Hi @dongjoon-hyun Shall we consider controlling versions we maintance on the UI instead of just pushing master to website?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1634: Fix some outdated descriptions in `Building ORC` documentation [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #1819: ORC-1634: Fix some outdated descriptions in `Building ORC` documentation
URL: https://github.com/apache/orc/pull/1819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1634: Fix some outdated descriptions in `Building ORC` documentation [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1819:
URL: https://github.com/apache/orc/pull/1819#discussion_r1503083852
##########
site/_docs/building.md:
##########
@@ -18,19 +18,18 @@ You'll want to install the usual set of developer tools, but at least:
* cmake
* g++ or clang++
-* java ( >= 1.8)
+* java ( >= 17)
* make
* maven ( >= 3)
For each version of Linux, please check the corresponding Dockerfile, which
is in the docker subdirectory, for the list of packages required to build ORC:
-* [CentOS 7]({{ page.dockerUrl }}/centos7/Dockerfile)
-* [Debian 10]({{ page.dockerUrl }}/debian10/Dockerfile)
* [Debian 11]({{ page.dockerUrl }}/debian11/Dockerfile)
* [Debian 12]({{ page.dockerUrl }}/debian12/Dockerfile)
* [Ubuntu 20]({{ page.dockerUrl }}/ubuntu20/Dockerfile)
* [Ubuntu 22]({{ page.dockerUrl }}/ubuntu22/Dockerfile)
+* [Ubuntu 24]({{ page.dockerUrl }}/ubuntu24/Dockerfile)
Review Comment:
Well, this is still outdated. `oraclelinux9`? Where did you reference when you make this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1634: Fix some outdated descriptions in `Building ORC` documentation [orc]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on PR #1819:
URL: https://github.com/apache/orc/pull/1819#issuecomment-1965690095
> we cannot publish this until Apache ORC 2.0 is released
Thanks, looking forward to the Apache ORC 2.0 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1634: Fix some outdated descriptions in `Building ORC` documentation [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #1819:
URL: https://github.com/apache/orc/pull/1819#discussion_r1503570469
##########
site/_docs/building.md:
##########
@@ -18,19 +18,18 @@ You'll want to install the usual set of developer tools, but at least:
* cmake
* g++ or clang++
-* java ( >= 1.8)
+* java ( >= 17)
* make
* maven ( >= 3)
For each version of Linux, please check the corresponding Dockerfile, which
is in the docker subdirectory, for the list of packages required to build ORC:
-* [CentOS 7]({{ page.dockerUrl }}/centos7/Dockerfile)
-* [Debian 10]({{ page.dockerUrl }}/debian10/Dockerfile)
* [Debian 11]({{ page.dockerUrl }}/debian11/Dockerfile)
* [Debian 12]({{ page.dockerUrl }}/debian12/Dockerfile)
* [Ubuntu 20]({{ page.dockerUrl }}/ubuntu20/Dockerfile)
* [Ubuntu 22]({{ page.dockerUrl }}/ubuntu22/Dockerfile)
+* [Ubuntu 24]({{ page.dockerUrl }}/ubuntu24/Dockerfile)
Review Comment:
Ya, this is good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1634: Fix some outdated descriptions in `Building ORC` documentation [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1819:
URL: https://github.com/apache/orc/pull/1819#issuecomment-1986522774
> Shall we consider controlling versions we maintance on the UI instead of just pushing master to website?
For the above, it's possible but it's a major restructuring.
1. At least, it requires to regenerate all versions' documentation and publish into the ORC website.
2. We need to split (and redesign) Apache ORC website structure into two groups: one is a main unchanged part and other others in the newly created versioned directory.
You can initiate the discussion at `dev@orc` mailing list, @cxzl25 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ORC-1634: Fix some outdated descriptions in `Building ORC` documentation [orc]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1819:
URL: https://github.com/apache/orc/pull/1819#issuecomment-1989477815
This is published to the Apache ORC website. Thank you!
- https://orc.apache.org/docs/building.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org