[GitHub] [hive] aturoczy commented on a diff in pull request #4609: [DRAFT] HIVE-27626: HiveBaseResultSet to return Hive's own Timestamp through getObject

["aturoczy (via GitHub)" <gi...@apache.org>]

aturoczy commented on code in PR #4609:
URL: https://github.com/apache/hive/pull/4609#discussion_r1301234230


##########
jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java:
##########
@@ -542,7 +542,7 @@ private Object evaluate(Type type, Object value) {
       }
       return value;
     case TIMESTAMP_TYPE:
-      return Timestamp.valueOf((String) value);
+      return org.apache.hadoop.hive.common.type.Timestamp.valueOf((String)value);

Review Comment:
   Sorry, but why is this Timestamp better? Please fill out the description. (Even for draft :) )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org