You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2021/06/01 20:59:19 UTC

[GitHub] [celix] pnoltes opened a new pull request #347: Feature/add intent to cxx rsa

pnoltes opened a new pull request #347:
URL: https://github.com/apache/celix/pull/347


   Adds initial remote intents and configuration support to the C++ remote service admin using the export/import service factories. 
   
   Intents:
   https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.remoteservices.html#i1693415
   
   Configuration:
   https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.remoteservices.html#i1693415


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] codecov-commenter edited a comment on pull request #347: Feature/add intent to cxx rsa

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #347:
URL: https://github.com/apache/celix/pull/347#issuecomment-852446307


   # [Codecov](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#347](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6452ca0) into [master](https://codecov.io/gh/apache/celix/commit/0cd23ad37ccb238f82a002321de4e396f08b2f85?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0cd23ad) will **increase** coverage by `0.06%`.
   > The diff coverage is `87.70%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/celix/pull/347/graphs/tree.svg?width=650&height=150&src=pr&token=JdsiThga8P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #347      +/-   ##
   ==========================================
   + Coverage   71.40%   71.46%   +0.06%     
   ==========================================
     Files         199      202       +3     
     Lines       35262    35320      +58     
   ==========================================
   + Hits        25178    25243      +65     
   + Misses      10084    10077       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../rsa\_spi/include/celix/rsa/IExportServiceFactory.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUV4cG9ydFNlcnZpY2VGYWN0b3J5Lmg=) | `100.00% <ø> (ø)` | |
   | [.../rsa\_spi/include/celix/rsa/IImportServiceFactory.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUltcG9ydFNlcnZpY2VGYWN0b3J5Lmg=) | `100.00% <ø> (ø)` | |
   | [...ration/src/TestExportImportRemoteServiceFactory.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2ludGVncmF0aW9uL3NyYy9UZXN0RXhwb3J0SW1wb3J0UmVtb3RlU2VydmljZUZhY3RvcnkuY2M=) | `81.89% <76.92%> (-0.80%)` | :arrow_down: |
   | [...xx\_remote\_services/admin/src/RemoteServiceAdmin.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2FkbWluL3NyYy9SZW1vdGVTZXJ2aWNlQWRtaW4uY2M=) | `78.70% <83.83%> (-1.71%)` | :arrow_down: |
   | [...\_services/admin/src/RemoteServiceAdminActivator.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2FkbWluL3NyYy9SZW1vdGVTZXJ2aWNlQWRtaW5BY3RpdmF0b3IuY2M=) | `100.00% <100.00%> (ø)` | |
   | [...ote\_services/integration/src/CalculatorProvider.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2ludGVncmF0aW9uL3NyYy9DYWxjdWxhdG9yUHJvdmlkZXIuY2M=) | `100.00% <100.00%> (ø)` | |
   | [...es/rsa\_spi/include/celix/rsa/EndpointDescription.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvRW5kcG9pbnREZXNjcmlwdGlvbi5o) | `90.90% <100.00%> (+1.25%)` | :arrow_up: |
   | [...es/rsa\_spi/include/celix/rsa/IExportRegistration.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUV4cG9ydFJlZ2lzdHJhdGlvbi5o) | `100.00% <100.00%> (ø)` | |
   | [...es/rsa\_spi/include/celix/rsa/IImportRegistration.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUltcG9ydFJlZ2lzdHJhdGlvbi5o) | `100.00% <100.00%> (ø)` | |
   | [...ndles/logging/log\_helper/include/celix/LogHelper.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9sb2dnaW5nL2xvZ19oZWxwZXIvaW5jbHVkZS9jZWxpeC9Mb2dIZWxwZXIuaA==) | `100.00% <100.00%> (ø)` | |
   | ... and [8 more](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0cd23ad...6452ca0](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] jermus67 commented on a change in pull request #347: Feature/add intent to cxx rsa

Posted by GitBox <gi...@apache.org>.
jermus67 commented on a change in pull request #347:
URL: https://github.com/apache/celix/pull/347#discussion_r643734167



##########
File path: bundles/cxx_remote_services/admin/gtest/src/RemoteServiceAdminTestSuite.cc
##########
@@ -87,7 +87,7 @@ class StubExportedServiceEntry {
     std::string cmpUUID{};
 };
 
-class StubExportServiceGuard : public celix::rsa::IExportServiceGuard {
+class StubExportServiceGuard : public celix::rsa::IExportRegistration {

Review comment:
       The name of the interface changed, shouldn't the name of the stub follow (in some way)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] codecov-commenter commented on pull request #347: Feature/add intent to cxx rsa

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #347:
URL: https://github.com/apache/celix/pull/347#issuecomment-852446307


   # [Codecov](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#347](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0aacbf9) into [master](https://codecov.io/gh/apache/celix/commit/0cd23ad37ccb238f82a002321de4e396f08b2f85?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0cd23ad) will **increase** coverage by `0.02%`.
   > The diff coverage is `86.41%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/celix/pull/347/graphs/tree.svg?width=650&height=150&src=pr&token=JdsiThga8P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #347      +/-   ##
   ==========================================
   + Coverage   71.40%   71.42%   +0.02%     
   ==========================================
     Files         199      202       +3     
     Lines       35262    35307      +45     
   ==========================================
   + Hits        25178    25219      +41     
   - Misses      10084    10088       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../rsa\_spi/include/celix/rsa/IExportServiceFactory.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUV4cG9ydFNlcnZpY2VGYWN0b3J5Lmg=) | `100.00% <ø> (ø)` | |
   | [.../rsa\_spi/include/celix/rsa/IImportServiceFactory.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUltcG9ydFNlcnZpY2VGYWN0b3J5Lmg=) | `100.00% <ø> (ø)` | |
   | [...ration/src/TestExportImportRemoteServiceFactory.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2ludGVncmF0aW9uL3NyYy9UZXN0RXhwb3J0SW1wb3J0UmVtb3RlU2VydmljZUZhY3RvcnkuY2M=) | `81.89% <70.00%> (-0.80%)` | :arrow_down: |
   | [...xx\_remote\_services/admin/src/RemoteServiceAdmin.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2FkbWluL3NyYy9SZW1vdGVTZXJ2aWNlQWRtaW4uY2M=) | `77.08% <81.81%> (-3.34%)` | :arrow_down: |
   | [...\_services/admin/src/RemoteServiceAdminActivator.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2FkbWluL3NyYy9SZW1vdGVTZXJ2aWNlQWRtaW5BY3RpdmF0b3IuY2M=) | `100.00% <100.00%> (ø)` | |
   | [...ote\_services/integration/src/CalculatorProvider.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2ludGVncmF0aW9uL3NyYy9DYWxjdWxhdG9yUHJvdmlkZXIuY2M=) | `100.00% <100.00%> (ø)` | |
   | [...es/rsa\_spi/include/celix/rsa/EndpointDescription.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvRW5kcG9pbnREZXNjcmlwdGlvbi5o) | `90.90% <100.00%> (+1.25%)` | :arrow_up: |
   | [...es/rsa\_spi/include/celix/rsa/IExportRegistration.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUV4cG9ydFJlZ2lzdHJhdGlvbi5o) | `100.00% <100.00%> (ø)` | |
   | [...es/rsa\_spi/include/celix/rsa/IImportRegistration.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUltcG9ydFJlZ2lzdHJhdGlvbi5o) | `100.00% <100.00%> (ø)` | |
   | [...ndles/logging/log\_helper/include/celix/LogHelper.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9sb2dnaW5nL2xvZ19oZWxwZXIvaW5jbHVkZS9jZWxpeC9Mb2dIZWxwZXIuaA==) | `100.00% <100.00%> (ø)` | |
   | ... and [5 more](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0cd23ad...0aacbf9](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] codecov-commenter edited a comment on pull request #347: Feature/add intent to cxx rsa

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #347:
URL: https://github.com/apache/celix/pull/347#issuecomment-852446307


   # [Codecov](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#347](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6452ca0) into [master](https://codecov.io/gh/apache/celix/commit/0cd23ad37ccb238f82a002321de4e396f08b2f85?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0cd23ad) will **increase** coverage by `0.17%`.
   > The diff coverage is `87.70%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/celix/pull/347/graphs/tree.svg?width=650&height=150&src=pr&token=JdsiThga8P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #347      +/-   ##
   ==========================================
   + Coverage   71.40%   71.58%   +0.17%     
   ==========================================
     Files         199      202       +3     
     Lines       35262    35480     +218     
   ==========================================
   + Hits        25178    25397     +219     
   + Misses      10084    10083       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../rsa\_spi/include/celix/rsa/IExportServiceFactory.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUV4cG9ydFNlcnZpY2VGYWN0b3J5Lmg=) | `100.00% <ø> (ø)` | |
   | [.../rsa\_spi/include/celix/rsa/IImportServiceFactory.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUltcG9ydFNlcnZpY2VGYWN0b3J5Lmg=) | `100.00% <ø> (ø)` | |
   | [...ration/src/TestExportImportRemoteServiceFactory.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2ludGVncmF0aW9uL3NyYy9UZXN0RXhwb3J0SW1wb3J0UmVtb3RlU2VydmljZUZhY3RvcnkuY2M=) | `81.89% <76.92%> (-0.80%)` | :arrow_down: |
   | [...xx\_remote\_services/admin/src/RemoteServiceAdmin.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2FkbWluL3NyYy9SZW1vdGVTZXJ2aWNlQWRtaW4uY2M=) | `78.70% <83.83%> (-1.71%)` | :arrow_down: |
   | [...\_services/admin/src/RemoteServiceAdminActivator.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2FkbWluL3NyYy9SZW1vdGVTZXJ2aWNlQWRtaW5BY3RpdmF0b3IuY2M=) | `100.00% <100.00%> (ø)` | |
   | [...ote\_services/integration/src/CalculatorProvider.cc](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL2ludGVncmF0aW9uL3NyYy9DYWxjdWxhdG9yUHJvdmlkZXIuY2M=) | `100.00% <100.00%> (ø)` | |
   | [...es/rsa\_spi/include/celix/rsa/EndpointDescription.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvRW5kcG9pbnREZXNjcmlwdGlvbi5o) | `90.90% <100.00%> (+1.25%)` | :arrow_up: |
   | [...es/rsa\_spi/include/celix/rsa/IExportRegistration.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUV4cG9ydFJlZ2lzdHJhdGlvbi5o) | `100.00% <100.00%> (ø)` | |
   | [...es/rsa\_spi/include/celix/rsa/IImportRegistration.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9jeHhfcmVtb3RlX3NlcnZpY2VzL3JzYV9zcGkvaW5jbHVkZS9jZWxpeC9yc2EvSUltcG9ydFJlZ2lzdHJhdGlvbi5o) | `100.00% <100.00%> (ø)` | |
   | [...ndles/logging/log\_helper/include/celix/LogHelper.h](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9sb2dnaW5nL2xvZ19oZWxwZXIvaW5jbHVkZS9jZWxpeC9Mb2dIZWxwZXIuaA==) | `100.00% <100.00%> (ø)` | |
   | ... and [8 more](https://codecov.io/gh/apache/celix/pull/347/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0cd23ad...6452ca0](https://codecov.io/gh/apache/celix/pull/347?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] pnoltes commented on a change in pull request #347: Feature/add intent to cxx rsa

Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #347:
URL: https://github.com/apache/celix/pull/347#discussion_r645646831



##########
File path: bundles/cxx_remote_services/admin/gtest/src/RemoteServiceAdminTestSuite.cc
##########
@@ -87,7 +87,7 @@ class StubExportedServiceEntry {
     std::string cmpUUID{};
 };
 
-class StubExportServiceGuard : public celix::rsa::IExportServiceGuard {
+class StubExportServiceGuard : public celix::rsa::IExportRegistration {

Review comment:
       renamed Stubs




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] pnoltes merged pull request #347: Feature/add intent to cxx rsa

Posted by GitBox <gi...@apache.org>.
pnoltes merged pull request #347:
URL: https://github.com/apache/celix/pull/347


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [celix] jermus67 commented on a change in pull request #347: Feature/add intent to cxx rsa

Posted by GitBox <gi...@apache.org>.
jermus67 commented on a change in pull request #347:
URL: https://github.com/apache/celix/pull/347#discussion_r643734167



##########
File path: bundles/cxx_remote_services/admin/gtest/src/RemoteServiceAdminTestSuite.cc
##########
@@ -87,7 +87,7 @@ class StubExportedServiceEntry {
     std::string cmpUUID{};
 };
 
-class StubExportServiceGuard : public celix::rsa::IExportServiceGuard {
+class StubExportServiceGuard : public celix::rsa::IExportRegistration {

Review comment:
       The name of the interface changed, shouldn't the name of the stub follow (in some way)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org