You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/29 10:52:23 UTC

[GitHub] [spark] WeichenXu123 commented on issue #25235: [SPARK-28483][Core] Fix canceling a spark job using barrier mode but barrier tasks blocking on BarrierTaskContext.barrier()

WeichenXu123 commented on issue #25235: [SPARK-28483][Core] Fix canceling a spark job using barrier mode but barrier tasks blocking on BarrierTaskContext.barrier()
URL: https://github.com/apache/spark/pull/25235#issuecomment-515943949
 
 
   I modify my approach, add an RPC interface like:
   ```
     def askCancelable[T: ClassTag](
         message: Any,
         timeout: RpcTimeout): CancelableFuture[T]
   ```
   See my PR description for details.
   
   This approach add less and simpler code into RPC framework.
   CC @zsxwing @cloud-fan 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org