You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/23 17:21:58 UTC

[GitHub] [airflow] maiorBoltach opened a new pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

maiorBoltach opened a new pull request #10878:
URL: https://github.com/apache/airflow/pull/10878


   **Summary**:
   Method 'on_load' should run on plugins initialization, that are located in plugin folder.
   Before method was triggered only for plugins in airflow.plugins.* entry points
   
   closes: #10868
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #10878:
URL: https://github.com/apache/airflow/pull/10878#discussion_r487804698



##########
File path: tests/plugins/test_plugins_manager.py
##########
@@ -121,6 +121,39 @@ class TestNonPropertyHook(BaseHook):
             self.assertIn('PluginPropertyOperator', str(plugins_manager.operators_modules[0].__dict__))
             self.assertIn("TestNonPropertyHook", str(plugins_manager.hooks_modules[0].__dict__))
 
+    def test_should_fail_on_register_plugin_with_incorrect_load(self):
+        class TestNonPropertyHook(BaseHook):
+            pass
+
+        class AirflowTestPlugin(AirflowPlugin):
+            name = "test_plugin"
+
+            hooks = []
+
+            @classmethod
+            def on_load(cls, *args, **kwargs):
+                cls.hooks.append(TestNonPropertyHook)
+
+        with mock_plugin_manager(plugins=[]):
+            from airflow import plugins_manager
+
+            plugins_manager.register_plugin(AirflowTestPlugin)
+            self.assertListEqual(plugins_manager.plugins, [AirflowTestPlugin])
+
+    def test_should_register_plugin(self):

Review comment:
       ```suggestion
       def test_should_fail_on_register_plugin_with_incorrect_load(self):
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

kaxil closed pull request #10878:
URL: https://github.com/apache/airflow/pull/10878


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

mik-laj commented on pull request #10878:
URL: https://github.com/apache/airflow/pull/10878#issuecomment-751265990


   @maiorBoltach  Any progress?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #10878:
URL: https://github.com/apache/airflow/pull/10878#issuecomment-691043352






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #10878:
URL: https://github.com/apache/airflow/pull/10878#issuecomment-691043352






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] closed pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

github-actions[bot] closed pull request #10878:
URL: https://github.com/apache/airflow/pull/10878


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] maiorBoltach commented on a change in pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

maiorBoltach commented on a change in pull request #10878:
URL: https://github.com/apache/airflow/pull/10878#discussion_r488506722



##########
File path: tests/plugins/test_plugins_manager.py
##########
@@ -121,6 +121,39 @@ class TestNonPropertyHook(BaseHook):
             self.assertIn('PluginPropertyOperator', str(plugins_manager.operators_modules[0].__dict__))
             self.assertIn("TestNonPropertyHook", str(plugins_manager.hooks_modules[0].__dict__))
 
+    def test_should_fail_on_register_plugin_with_incorrect_load(self):
+        class TestNonPropertyHook(BaseHook):
+            pass
+
+        class AirflowTestPlugin(AirflowPlugin):
+            name = "test_plugin"
+
+            hooks = []
+
+            @classmethod
+            def on_load(cls, *args, **kwargs):
+                cls.hooks.append(TestNonPropertyHook)
+
+        with mock_plugin_manager(plugins=[]):
+            from airflow import plugins_manager
+
+            plugins_manager.register_plugin(AirflowTestPlugin)
+            self.assertListEqual(plugins_manager.plugins, [AirflowTestPlugin])
+
+    def test_should_register_plugin(self):

Review comment:
       Thanks, mixed up the names of the methods




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #10878:
URL: https://github.com/apache/airflow/pull/10878#issuecomment-691043352

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on pull request #10878:
URL: https://github.com/apache/airflow/pull/10878#issuecomment-691043352

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] stale[bot] commented on pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

stale[bot] commented on pull request #10878:
URL: https://github.com/apache/airflow/pull/10878#issuecomment-751246646


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

mik-laj commented on a change in pull request #10878:
URL: https://github.com/apache/airflow/pull/10878#discussion_r487804607



##########
File path: tests/plugins/test_plugins_manager.py
##########
@@ -121,6 +121,39 @@ class TestNonPropertyHook(BaseHook):
             self.assertIn('PluginPropertyOperator', str(plugins_manager.operators_modules[0].__dict__))
             self.assertIn("TestNonPropertyHook", str(plugins_manager.hooks_modules[0].__dict__))
 
+    def test_should_fail_on_register_plugin_with_incorrect_load(self):

Review comment:
       ```suggestion
       def test_should_register_plugin(self):
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #10878: Fix missing on_load trigger for folder-based plugins (#10868)

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #10878:
URL: https://github.com/apache/airflow/pull/10878#issuecomment-792130068


   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org