You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/18 17:44:46 UTC
[GitHub] [incubator-superset] michael-s-molina opened a new pull request #12125: Improves chart save and go button
michael-s-molina opened a new pull request #12125:
URL: https://github.com/apache/incubator-superset/pull/12125
Resolves #11748
### ANIMATED GIF

### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #12125: fix: Fix chart save and go button
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #12125:
URL: https://github.com/apache/incubator-superset/pull/12125#issuecomment-748324531
> LGTM. Could you confirm whether this added `dashboardId` will persist in chart formData when you save? (It probably shouldn't. But shouldn't be a problem if it does.)
Thanks @ktmud - this is a good catch. Agree that it's non-blocking, so I hit the big green button, but @michael-s-molina if you could confirm and file another PR to fix if it's persisting that, it would be appreciated! And thank you for this great UX improvement!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] michael-s-molina commented on pull request #12125: fix: Fix chart save and go button
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #12125:
URL: https://github.com/apache/incubator-superset/pull/12125#issuecomment-748965511
@ktmud @rusackas I checked and it's not persisting.
The `getFormDataFromControls(explore.controls)` in `ExploreViewContainer.jsx` returns a `form_data` without the `dashboardId` because there is no such property in controls schema.
function mapStateToProps(state) {
const { explore, charts, impressionId } = state;
const form_data = getFormDataFromControls(explore.controls);
...
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] michael-s-molina edited a comment on pull request #12125: fix: Fix chart save and go button
Posted by GitBox <gi...@apache.org>.
michael-s-molina edited a comment on pull request #12125:
URL: https://github.com/apache/incubator-superset/pull/12125#issuecomment-748965511
@ktmud @rusackas I checked and it's not persisting.
The `getFormDataFromControls(explore.controls)` in `ExploreViewContainer.jsx` returns a `form_data` without the `dashboardId` because there is no such property in controls schema.
```
function mapStateToProps(state) {
const { explore, charts, impressionId } = state;
const form_data = getFormDataFromControls(explore.controls);
...
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #12125: fix: Fix chart save and go button
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12125:
URL: https://github.com/apache/incubator-superset/pull/12125#issuecomment-748307337
Thanks for catching this use case and making Superset more intuitive to use, @junlincc !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #12125: fix: Fix chart save and go button
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12125:
URL: https://github.com/apache/incubator-superset/pull/12125
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org