You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by swkimme <gi...@git.apache.org> on 2016/05/31 03:13:51 UTC
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-905] fix failed noteboo...
GitHub user swkimme opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/933
[ZEPPELIN-905] fix failed notebook import bug
### What is this PR for?
When notebook has a result with Exceptions, it always fail to import. This PR fix it.
### What type of PR is it?
Bug Fix
### Todos
* [x] - Fix this bug by ignore the result with error.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-905
### How should this be tested?
Create notebook with error, then try to import.
### Questions:
* Does the licenses files need update? X
* Is there breaking changes for older versions? X
* Does this needs documentation? X
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swkimme/incubator-zeppelin zeppelin-905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/933.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #933
----
commit f8620cff7b1109176e7100fda5d06358f1ae792f
Author: Kevin Kim <sa...@gmail.com>
Date: 2016-05-31T03:05:30Z
[ZEPPELIN-905] fix failed notebook import bug
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-905] fix failed noteboo...
Posted by swkimme <gi...@git.apache.org>.
Github user swkimme commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/933#issuecomment-222617200
@Leemoonsoo Do you know why the CI test failed btw?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #933: [ZEPPELIN-905] fix failed notebook import bug
Posted by swkimme <gi...@git.apache.org>.
Github user swkimme commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/933
@bzz @felixcheung Good idea, updated log and comment!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-905] fix failed noteboo...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/933#issuecomment-222590736
Looks good to me.
How about adding an unittest for it in [NotebookTest.java](https://github.com/apache/incubator-zeppelin/blob/18fa33a9b1127efd7b05980427fc61871b41f593/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java#L312)? Let me know if you need help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-905] fix failed noteboo...
Posted by swkimme <gi...@git.apache.org>.
Github user swkimme commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/933#issuecomment-222594140
@Leemoonsoo
I've added some test!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-905] fix failed noteboo...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/933#issuecomment-222641325
@swkimme I think this is failing because you are trying to get paragraph result i.e. `p.getResult()` or `p2.getResult()` without running any of the paragraph.
try having
note.runAll();
while(p.isTerminated()==false || p.getResult()==null) Thread.yield();
importedNote.runAll();
while(p2.isTerminated()==false || p2.getResult()==null) Thread.yield();
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---