You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@turbine.apache.org by "Thomas Vandahl (JIRA)" <ji...@apache.org> on 2009/01/06 22:05:44 UTC

[jira] Closed: (TRB-9) Intake: Handling of empty values

     [ https://issues.apache.org/jira/browse/TRB-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Vandahl closed TRB-9.
----------------------------


Fix is in 2.3.3-release

> Intake: Handling of empty values
> --------------------------------
>
>                 Key: TRB-9
>                 URL: https://issues.apache.org/jira/browse/TRB-9
>             Project: Turbine
>          Issue Type: Bug
>          Components: Turbine 2.3
>    Affects Versions: Core 2.3.2
>            Reporter: Stefan Broetz
>            Priority: Blocker
>         Attachments: patch_TRB-9.txt
>
>
> It seems to be impossible transmit the empty string as a value: In the HTTP request
>   http://.../turbine/...?aaa=123&bbb=&ccc=456
> the parameter bbb is ignored.
> If you look at org.apache.turbine.services.intake.model.Field.init(ValueParser pp) you find:
>         if (pp.containsKey(getKey()))
>         {
>             if (isDebugEnabled)
>             {
>                 log.debug(name + ": Found our Key in the request, setting Value");
>             }
>             if (StringUtils.isNotEmpty(pp.getString(getKey())))
>             {
>                 setFlag = true;
>             }
>             validate();
>         }
>         else if (pp.containsKey(getValueIfAbsent()) &&
>                 pp.getString(getValueIfAbsent()) != null)
>         {
>             pp.add(getKey(), pp.getString(getValueIfAbsent()));
>             setFlag = true;
>             validate();
>         }
> The StringUtils.isNotEmpty() condition (line 342) prevents that a field can take up the empty string as its value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.