[GitHub] [linkis] peacewong commented on a diff in pull request #4428: Merge 1.3.2 to1.4.0

["peacewong (via GitHub)" <gi...@apache.org>]

peacewong commented on code in PR #4428:
URL: https://github.com/apache/linkis/pull/4428#discussion_r1154081409


##########
linkis-dist/package/db/linkis_ddl.sql:
##########
@@ -42,6 +42,9 @@ CREATE TABLE `linkis_ps_configuration_config_key`(
   `is_advanced` tinyint(1) DEFAULT NULL COMMENT 'Whether it is an advanced parameter. If set to 1(true), parameters would be displayed only when user choose to do so',
   `level` tinyint(1) DEFAULT NULL COMMENT 'Basis for displaying sorting in the front-end. Higher the level is, higher the rank the parameter gets',
   `treeName` varchar(20) DEFAULT NULL COMMENT 'Reserved field, representing the subdirectory of engineType',
+  `en_description` varchar(200) DEFAULT NULL COMMENT 'english description',
+  `en_name` varchar(100) DEFAULT NULL COMMENT 'english name',
+  `en_treeName` varchar(100) DEFAULT NULL COMMENT 'english treeName',

Review Comment:
   Yes, this is already in package/db/upgrade/1.3.2_schema/mysql/linkis_ddl.sql



##########
linkis-dist/package/db/linkis_ddl.sql:
##########
@@ -907,6 +911,9 @@ CREATE TABLE `linkis_ps_dm_datasource_type`
     `classifier`  varchar(32) COLLATE utf8_bin NOT NULL,
     `icon`        varchar(255) COLLATE utf8_bin DEFAULT NULL,
     `layers`      int(3)                       NOT NULL,
+    `description_en` varchar(255) DEFAULT NULL COMMENT 'english description',

Review Comment:
   Yes, this is already in package/db/upgrade/1.3.2_schema/mysql/linkis_ddl.sql



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org