You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/06/02 03:04:37 UTC
[GitHub] [bookkeeper] lamber-ken opened a new pull request #2344: [SITE] Improve the user experience of the site
lamber-ken opened a new pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344
### Motivation
Improve the user experience of the site.
### Changes
**Compare:**
https://lamber-ken.github.io/docs/4.10.0/getting-started/installation/
https://bookkeeper.apache.org/docs/4.10.0/getting-started/installation/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mino181295 commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
mino181295 commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-632569140
Maybe it's a good idea to hide the right column when the with is 769~1200
Take a look at the **variables.sass and helpers.sass**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lamber-ken commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-633762998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mino181295 commented on a change in pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
mino181295 commented on a change in pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#discussion_r429110747
##########
File path: site/css/style.sass
##########
@@ -81,9 +81,9 @@ footer.footer
.toc
overflow-y: scroll
bottom: 0
- top: $navbar-height + 5rem
+ top: 50px
Review comment:
Change the $navbar-height variable instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lamber-ken commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-637242655
Agree with you all @eolivelli @sijie
- https://docusaurus.io/ Look nicer
- this pr can improve the user experience of the website in use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lamber-ken commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-643803157
> Awesome stuff @lamber-ken!
> Also, if you're interested, we can start an email chain in dev to start scoping out the move to docusaurus.io
Thanks, will check the mail list : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mino181295 commented on a change in pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
mino181295 commented on a change in pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#discussion_r429114496
##########
File path: site/css/style.sass
##########
@@ -81,9 +81,9 @@ footer.footer
.toc
overflow-y: scroll
bottom: 0
- top: $navbar-height + 5rem
+ top: 50px
Review comment:
Change the $navbar-height variable instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-632547441
@mino181295 PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lamber-ken edited a comment on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-637242655
Agree with you all @eolivelli @sijie
- https://docusaurus.io/ Look nicer
- this pr can improve the user experience of the current website
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lamber-ken commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-632572748
Thanks @mino181295, let's me have a try.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lamber-ken commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-632522066
Any suggestion are welcome 😃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mino181295 commented on a change in pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
mino181295 commented on a change in pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#discussion_r429110747
##########
File path: site/css/style.sass
##########
@@ -81,9 +81,9 @@ footer.footer
.toc
overflow-y: scroll
bottom: 0
- top: $navbar-height + 5rem
+ top: 50px
Review comment:
Change the $navbar-height variable instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-640571337
@mino181295 are you ok with merging current patch in this form ?
@sijie we can switch to a new framework later
it looks like we do not have much energy these days in the community
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lamber-ken closed pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
lamber-ken closed pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] mino181295 commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
mino181295 commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-640588480
Yes, to me it's ok!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Ghatage commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
Ghatage commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-643570104
Awesome stuff @lamber-ken!
Also, if you're interested, we can start an email chain in dev to start scoping out the move to docusaurus.io
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-636521881
But if this fix helps in improving the website we can commit it as a hot fix.
It will take a lot of time to migrate to another system
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lamber-ken commented on a change in pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#discussion_r429567335
##########
File path: site/css/style.sass
##########
@@ -81,9 +81,9 @@ footer.footer
.toc
overflow-y: scroll
bottom: 0
- top: $navbar-height + 5rem
+ top: 50px
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-664155070
This is a minor change and does not have impact in production code, I will commit it, no need for a second binding +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lamber-ken commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-636513709
> I think the website was customized site. It is hard to maintain the site. I would suggest us migrating the documentation site to use https://docusaurus.io/ as what we do for pulsar.
https://docusaurus.io/ Look nice, 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lamber-ken edited a comment on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-633762998
hi @mino181295 @eolivelli, I had tried several times, but failed. Compared to old site, I can improve the following three parts, so this pr is ready for merge, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] sijie commented on pull request #2344: [SITE] Improve the user experience of the site
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #2344:
URL: https://github.com/apache/bookkeeper/pull/2344#issuecomment-636364183
I think the website was customized site. It is hard to maintain the site. I would suggest us migrating the documentation site to use https://docusaurus.io/ as what we do for pulsar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org