You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by jdanekrh <gi...@git.apache.org> on 2017/11/17 20:45:32 UTC

[GitHub] qpid-proton pull request #130: Add coverage reporting for the Ruby binding

GitHub user jdanekrh opened a pull request:

    https://github.com/apache/qpid-proton/pull/130

    Add coverage reporting for the Ruby binding

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdanekrh/qpid-proton jd_cov_ruby

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #130
    
----
commit 0633111631fc9e3b43ff19960f7b2bfc33331282
Author: Jiri Danek <jd...@redhat.com>
Date:   2017-11-17T11:38:34Z

    Add coverage reporting for the Ruby binding

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] qpid-proton issue #130: Add coverage reporting for the Ruby binding

Posted by ssorj <gi...@git.apache.org>.
Github user ssorj commented on the issue:

    https://github.com/apache/qpid-proton/pull/130
  
    We'll get this when 0.20.0 opens.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] qpid-proton issue #130: Add coverage reporting for the Ruby binding

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/qpid-proton/pull/130
  
    # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=h1) Report
    > Merging [#130](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-proton/commit/9de60a86f5bdb3a47bfc0015a1e5ff9c595fa5de?src=pr&el=desc) will **decrease** coverage by `0.38%`.
    > The diff coverage is `n/a`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-proton/pull/130/graphs/tree.svg?token=UKKzV9XnFF&width=650&height=150&src=pr)](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #130      +/-   ##
    ==========================================
    - Coverage   78.65%   78.27%   -0.39%     
    ==========================================
      Files         231      300      +69     
      Lines       30552    33493    +2941     
      Branches     2905     2903       -2     
    ==========================================
    + Hits        24032    26216    +2184     
    - Misses       4878     5640     +762     
    + Partials     1642     1637       -5
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree) | Coverage Δ | |
    |---|---|---|
    | [examples/cpp/scheduled\_send\_03.cpp](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree#diff-ZXhhbXBsZXMvY3BwL3NjaGVkdWxlZF9zZW5kXzAzLmNwcA==) | `84.44% <0%> (-2.23%)` | :arrow_down: |
    | [proton-c/bindings/ruby/lib/util/condition.rb](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvcnVieS9saWIvdXRpbC9jb25kaXRpb24ucmI=) | `68.18% <0%> (ø)` | |
    | [...dings/ruby/lib/handler/incoming\_message\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvcnVieS9saWIvaGFuZGxlci9pbmNvbWluZ19tZXNzYWdlX2hhbmRsZXIucmI=) | `64.51% <0%> (ø)` | |
    | [proton-c/bindings/ruby/lib/core/transport.rb](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvcnVieS9saWIvY29yZS90cmFuc3BvcnQucmI=) | `75.64% <0%> (ø)` | |
    | [proton-c/bindings/ruby/lib/reactor/ssl\_config.rb](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvcnVieS9saWIvcmVhY3Rvci9zc2xfY29uZmlnLnJi) | `45.45% <0%> (ø)` | |
    | [proton-c/bindings/ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvcnVieS9saWIvY29kZWMvZGF0YS5yYg==) | `93.2% <0%> (ø)` | |
    | [proton-c/bindings/ruby/lib/util/wrapper.rb](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvcnVieS9saWIvdXRpbC93cmFwcGVyLnJi) | `92.68% <0%> (ø)` | |
    | [proton-c/bindings/ruby/lib/reactor/reactor.rb](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvcnVieS9saWIvcmVhY3Rvci9yZWFjdG9yLnJi) | `31.31% <0%> (ø)` | |
    | [proton-c/bindings/ruby/lib/core/ssl.rb](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvcnVieS9saWIvY29yZS9zc2wucmI=) | `41.86% <0%> (ø)` | |
    | [proton-c/bindings/ruby/tests/test\_tools.rb](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree#diff-cHJvdG9uLWMvYmluZGluZ3MvcnVieS90ZXN0cy90ZXN0X3Rvb2xzLnJi) | `74.54% <0%> (ø)` | |
    | ... and [67 more](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=tree-more) | |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=footer). Last update [9de60a8...698cb38](https://codecov.io/gh/apache/qpid-proton/pull/130?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org