You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by Dave <sn...@gmail.com> on 2021/08/08 19:57:41 UTC
VOTE: Release Apache Roller 6.0.2
Please vote to release the release candidate (RC2) at the link below as
Apache Roller 6.0.2
The release candidate is here
https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.2/
Please vote +1 to release or -1 with reasons not to release.
This release includes the minor changes listed below:
Parse referrer URL instead of using string value directly
https://github.com/apache/roller/pull/90
Improved: the UI for the blog entries page
https://github.com/apache/roller/pull/87
Improved: tooltip content on the registration form
https://github.com/apache/roller/pull/89
Updated: the main menu to have proper space when displaying permission
message
https://github.com/apache/roller/pull/95
Updated: the header to show the tagline only when it's available
https://github.com/apache/roller/pull/99
UI fixes are thanks to new contributor Yash Maheshwari.
Best regards,
Dave
[VOTE RESULT] Release Apache Roller 6.0.2
Posted by Dave <sn...@gmail.com>.
The release vote passed with 4 binding votes:
Aditya +1
Greg +1
Michael +1
Dave +1
I start the process of copying the release files to ASF mirrors and will
announce the release once that is done. Thanks everybody!
Dave
On Wed, Aug 11, 2021 at 1:57 AM Aditya Sharma <ad...@apache.org>
wrote:
> +1
>
> Thanks and Regards,
> Aditya Sharma
>
> On Mon, 9 Aug 2021 at 01:27, Dave <sn...@gmail.com> wrote:
>
> > Please vote to release the release candidate (RC2) at the link below as
> > Apache Roller 6.0.2
> > The release candidate is here
> > https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.2/
> >
> > Please vote +1 to release or -1 with reasons not to release.
> >
> >
> > This release includes the minor changes listed below:
> >
> > Parse referrer URL instead of using string value directly
> > https://github.com/apache/roller/pull/90
> >
> > Improved: the UI for the blog entries page
> > https://github.com/apache/roller/pull/87
> >
> > Improved: tooltip content on the registration form
> > https://github.com/apache/roller/pull/89
> >
> > Updated: the main menu to have proper space when displaying permission
> > message
> > https://github.com/apache/roller/pull/95
> >
> > Updated: the header to show the tagline only when it's available
> > https://github.com/apache/roller/pull/99
> >
> >
> > UI fixes are thanks to new contributor Yash Maheshwari.
> >
> > Best regards,
> > Dave
> >
>
Re: VOTE: Release Apache Roller 6.0.2
Posted by Aditya Sharma <ad...@apache.org>.
+1
Thanks and Regards,
Aditya Sharma
On Mon, 9 Aug 2021 at 01:27, Dave <sn...@gmail.com> wrote:
> Please vote to release the release candidate (RC2) at the link below as
> Apache Roller 6.0.2
> The release candidate is here
> https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.2/
>
> Please vote +1 to release or -1 with reasons not to release.
>
>
> This release includes the minor changes listed below:
>
> Parse referrer URL instead of using string value directly
> https://github.com/apache/roller/pull/90
>
> Improved: the UI for the blog entries page
> https://github.com/apache/roller/pull/87
>
> Improved: tooltip content on the registration form
> https://github.com/apache/roller/pull/89
>
> Updated: the main menu to have proper space when displaying permission
> message
> https://github.com/apache/roller/pull/95
>
> Updated: the header to show the tagline only when it's available
> https://github.com/apache/roller/pull/99
>
>
> UI fixes are thanks to new contributor Yash Maheshwari.
>
> Best regards,
> Dave
>
Re: VOTE: Release Apache Roller 6.0.2
Posted by Michael Bien <mb...@gmail.com>.
+1
I did some minimal manual testing (create blog+user, post entry etc) in
a container and everything worked fine.
-michael
On 08.08.21 21:57, Dave wrote:
> Please vote to release the release candidate (RC2) at the link below as
> Apache Roller 6.0.2
> The release candidate is here
> https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.2/
>
> Please vote +1 to release or -1 with reasons not to release.
>
>
> This release includes the minor changes listed below:
>
> Parse referrer URL instead of using string value directly
> https://github.com/apache/roller/pull/90
>
> Improved: the UI for the blog entries page
> https://github.com/apache/roller/pull/87
>
> Improved: tooltip content on the registration form
> https://github.com/apache/roller/pull/89
>
> Updated: the main menu to have proper space when displaying permission
> message
> https://github.com/apache/roller/pull/95
>
> Updated: the header to show the tagline only when it's available
> https://github.com/apache/roller/pull/99
>
>
> UI fixes are thanks to new contributor Yash Maheshwari.
>
> Best regards,
> Dave
>
Re: MediaFileView.jsp
Posted by Greg Huber <gr...@gmail.com>.
...Sorry, sent too soon,
Below comes from the
http://127.0.0.1:8080/roller/roller-ui/authoring/bookmarks.rol?weblog=testuser
menu.
08:06:25.493 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks)
could not locate the message resource with key 'default'
08:06:25.493 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks)
could not locate the message resource with key 'default'
08:06:25.494 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The default value
expression 'default' was evaluated and did not match a property. The
literal value 'default' will be used.
08:06:25.494 [http-nio-8080-exec-9] WARN
org.apache.struts2.util.TextProviderHelper - The default value
expression 'default' was evaluated and did not match a property. The
literal value 'default' will be used.
Cheers Greg
On 09/08/2021 17:46, Michael Bien wrote:
> On 09.08.21 09:51, Greg Huber wrote:
>> Spotted this one when deleting a folder:
>>
>> MediaFileView.jsp
>>
>> function onDeleteFolder() {
>> if (confirm("<s:text name='mediaFile.deleteFolder.confirm'
>> />")) {
>> document.bookmarks.action = '<s:url
>> action="mediaFileView!deleteFolder" />';
>> document.bookmarks.submit();
>> }
>> }
>>
>> guess it should be: document.mediaFileViewForm.action and
>> document.mediaFileViewForm.submit();
>
> looks like a copy and paste bug on first glance. However deleting
> folders actually works, right? I ran a quick test and the folder is gone.
>
>
>>
>> Also where is the bookmarks page link now? editor-menu.xml, for
>> weblogPerms="admin"
>>
>> <!-- globalPerms="login" -->
>> <menu-item action="bookmarks"
>> name="tabbedmenu.bookmarks.allFolders"
>> weblogPerms="admin"
>> subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport"
>> />
>
> Its called Blogroll in the menu
> (/roller-ui/authoring/bookmarks.rol?weblog=blog)
>
> the admin user might not have this menu unless the admin has a blog too.
>
> best regards,
>
> michael
>
Re: MediaFileView.jsp
Posted by Michael Bien <mb...@gmail.com>.
On 10.08.21 09:05, Greg Huber wrote:
> > looks like a copy and paste bug on first glance. However deleting
> folders actually works, right? I ran a quick test and the folder is gone.
>
> Yes it works, but I get this error in the console (forgot to add this
> to the first email) after delete:
>
> Uncaught TypeError: document.bookmarks is undefined
> onDeleteFolder
> http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:956
> onclick
> http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:1
oh, *that* console :) It looks like it is failing in a good way since it
is actually unable to delete bookmarks with that context.
fix -> https://github.com/apache/roller/pull/101
I don't feel its a show stopper for the update release.
regards,
michael
Re: MediaFileView.jsp
Posted by Greg Huber <gr...@gmail.com>.
> looks like a copy and paste bug on first glance. However deleting
folders actually works, right? I ran a quick test and the folder is gone.
Yes it works, but I get this error in the console (forgot to add this to
the first email) after delete:
Uncaught TypeError: document.bookmarks is undefined
onDeleteFolder
http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:956
onclick
http://127.0.0.1:8080/roller/roller-ui/authoring/mediaFileView!createNewDirectory.rol:1
##
>Its called Blogroll...
OK name change.
Cheers Greg
On 09/08/2021 17:46, Michael Bien wrote:
> On 09.08.21 09:51, Greg Huber wrote:
>> Spotted this one when deleting a folder:
>>
>> MediaFileView.jsp
>>
>> function onDeleteFolder() {
>> if (confirm("<s:text name='mediaFile.deleteFolder.confirm'
>> />")) {
>> document.bookmarks.action = '<s:url
>> action="mediaFileView!deleteFolder" />';
>> document.bookmarks.submit();
>> }
>> }
>>
>> guess it should be: document.mediaFileViewForm.action and
>> document.mediaFileViewForm.submit();
>
> looks like a copy and paste bug on first glance. However deleting
> folders actually works, right? I ran a quick test and the folder is gone.
>
>
>>
>> Also where is the bookmarks page link now? editor-menu.xml, for
>> weblogPerms="admin"
>>
>> <!-- globalPerms="login" -->
>> <menu-item action="bookmarks"
>> name="tabbedmenu.bookmarks.allFolders"
>> weblogPerms="admin"
>> subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport"
>> />
>
> Its called Blogroll in the menu
> (/roller-ui/authoring/bookmarks.rol?weblog=blog)
>
> the admin user might not have this menu unless the admin has a blog too.
>
> best regards,
>
> michael
>
Re: MediaFileView.jsp
Posted by Michael Bien <mb...@gmail.com>.
On 09.08.21 09:51, Greg Huber wrote:
> Spotted this one when deleting a folder:
>
> MediaFileView.jsp
>
> function onDeleteFolder() {
> if (confirm("<s:text name='mediaFile.deleteFolder.confirm'
> />")) {
> document.bookmarks.action = '<s:url
> action="mediaFileView!deleteFolder" />';
> document.bookmarks.submit();
> }
> }
>
> guess it should be: document.mediaFileViewForm.action and
> document.mediaFileViewForm.submit();
looks like a copy and paste bug on first glance. However deleting
folders actually works, right? I ran a quick test and the folder is gone.
>
> Also where is the bookmarks page link now? editor-menu.xml, for
> weblogPerms="admin"
>
> <!-- globalPerms="login" -->
> <menu-item action="bookmarks"
> name="tabbedmenu.bookmarks.allFolders"
> weblogPerms="admin"
> subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport"
> />
Its called Blogroll in the menu
(/roller-ui/authoring/bookmarks.rol?weblog=blog)
the admin user might not have this menu unless the admin has a blog too.
best regards,
michael
Re: VOTE: Release Apache Roller 6.0.2
Posted by Greg Huber <gr...@gmail.com>.
From the listed changes, seems OK +1(b)
####
Spotted this one when deleting a folder:
MediaFileView.jsp
function onDeleteFolder() {
if (confirm("<s:text name='mediaFile.deleteFolder.confirm' />")) {
document.bookmarks.action = '<s:url
action="mediaFileView!deleteFolder" />';
document.bookmarks.submit();
}
}
guess it should be: document.mediaFileViewForm.action and
document.mediaFileViewForm.submit();
Possibly related??
08:16:23.977 [http-nio-8080-exec-2] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks)
could not locate the message resource with key 'default'
08:16:23.977 [http-nio-8080-exec-2] WARN
org.apache.struts2.util.TextProviderHelper - The first TextProvider in
the ValueStack (org.apache.roller.weblogger.ui.struts2.editor.Bookmarks)
could not locate the message resource with key 'default'
08:16:23.999 [http-nio-8080-exec-2] WARN
org.apache.struts2.util.TextProviderHelper - The default value
expression 'default' was evaluated and did not match a property. The
literal value 'default' will be used.
08:16:23.999 [http-nio-8080-exec-2] WARN
org.apache.struts2.util.TextProviderHelper - The default value
expression 'default' was evaluated and did not match a property. The
literal value 'default' will be used.
####
Also where is the bookmarks page link now? editor-menu.xml, for
weblogPerms="admin"
<!-- globalPerms="login" -->
<menu-item action="bookmarks"
name="tabbedmenu.bookmarks.allFolders"
weblogPerms="admin"
subactions="bookmarkAdd,bookmarkEdit,folderAdd,folderEdit,bookmarksImport"
/>
Cheers Greg
On 08/08/2021 20:57, Dave wrote:
> Please vote to release the release candidate (RC2) at the link below as
> Apache Roller 6.0.2
> The release candidate is here
> https://dist.apache.org/repos/dist/dev/roller/roller-6.0/v6.0.2/
>
> Please vote +1 to release or -1 with reasons not to release.
>
>
> This release includes the minor changes listed below:
>
> Parse referrer URL instead of using string value directly
> https://github.com/apache/roller/pull/90
>
> Improved: the UI for the blog entries page
> https://github.com/apache/roller/pull/87
>
> Improved: tooltip content on the registration form
> https://github.com/apache/roller/pull/89
>
> Updated: the main menu to have proper space when displaying permission
> message
> https://github.com/apache/roller/pull/95
>
> Updated: the header to show the tagline only when it's available
> https://github.com/apache/roller/pull/99
>
>
> UI fixes are thanks to new contributor Yash Maheshwari.
>
> Best regards,
> Dave
>