You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2016/03/21 17:05:50 UTC

Review Request 45109: Fix "unnecessary" PMD issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45109/
-----------------------------------------------------------

Review request for ranger.


Repository: ranger


Description
-------

Fix "unnecessary" PMD issues


Diffs
-----

  agents-audit/src/main/java/org/apache/ranger/audit/provider/BufferedAuditProvider.java ca842f3 
  agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 83eb324 
  agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java 449cf55 
  dev-support/ranger-pmd-ruleset.xml 4db1881 
  hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java fb912c3 
  knox-agent/src/main/java/org/apache/ranger/authorization/knox/KnoxRangerPlugin.java 70ecd04 
  ranger-knox-plugin-shim/src/main/java/org/apache/ranger/authorization/knox/deploy/RangerPDPKnoxDeploymentContributor.java e927ba6 
  ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoader.java e0c9f61 
  ranger_solrj/src/main/java/org/apache/solr/common/SolrException.java 02bbc04 
  security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java aa26340 
  security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 02d725f 
  security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java 9867bb0 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefWithAssignedIdService.java 7fc54b1 
  security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java e118494 
  security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java c20373d 
  security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 77d6c8c 

Diff: https://reviews.apache.org/r/45109/diff/


Testing
-------


Thanks,

Colm O hEigeartaigh


Re: Review Request 45109: Fix "unnecessary" PMD issues

Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45109/#review124612
-----------------------------------------------------------


Ship it!




+1

- Alok Lal


On March 21, 2016, 9:05 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45109/
> -----------------------------------------------------------
> 
> (Updated March 21, 2016, 9:05 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Fix "unnecessary" PMD issues
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/BufferedAuditProvider.java ca842f3 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java 83eb324 
>   agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java 449cf55 
>   dev-support/ranger-pmd-ruleset.xml 4db1881 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java fb912c3 
>   knox-agent/src/main/java/org/apache/ranger/authorization/knox/KnoxRangerPlugin.java 70ecd04 
>   ranger-knox-plugin-shim/src/main/java/org/apache/ranger/authorization/knox/deploy/RangerPDPKnoxDeploymentContributor.java e927ba6 
>   ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoader.java e0c9f61 
>   ranger_solrj/src/main/java/org/apache/solr/common/SolrException.java 02bbc04 
>   security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java aa26340 
>   security-admin/src/main/java/org/apache/ranger/biz/XAuditMgr.java 02d725f 
>   security-admin/src/main/java/org/apache/ranger/security/web/filter/MyRememberMeFilter.java 9867bb0 
>   security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefWithAssignedIdService.java 7fc54b1 
>   security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java e118494 
>   security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java c20373d 
>   security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 77d6c8c 
> 
> Diff: https://reviews.apache.org/r/45109/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>