You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Appy (JIRA)" <ji...@apache.org> on 2017/09/05 22:11:00 UTC
[jira] [Comment Edited] (HBASE-18697) Need a shaded hbase-mapreduce
module
[ https://issues.apache.org/jira/browse/HBASE-18697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154327#comment-16154327 ]
Appy edited comment on HBASE-18697 at 9/5/17 10:10 PM:
-------------------------------------------------------
So to make sure that the change is orthogonal to invariant failures happening on current master, i ran the tests first on master hash 8a800c3f196fcbc3ed63f0967025c1779c43d486 (aug 31) and then with the patch. Here are the outputs.
Master @8a800c3f196fcbc3ed63f0967025c1779c43d486
{noformat}
$ mvn clean -Dtest=noUnitTests -pl hbase-shaded/hbase-shaded-check-invariants -am -Prelease verify
...
[INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ hbase-shaded-check-invariants ---
[INFO] Artifact looks correct: 'hbase-shaded-server-3.0.0-SNAPSHOT.jar'
[INFO] Artifact looks correct: 'hbase-shaded-client-3.0.0-SNAPSHOT.jar'
{noformat}
--Master @8a800c3f196fcbc3ed63f0967025c1779c43d486--
*Edit: Ignore this output. I ran this directly after previous command assuming it was updating jars in my repo. But it wasn't, since it's 'verify' and not 'install'.*
{noformat}
$ mvn -f ~/.m2/repository/org/apache/hbase/hbase-shaded-server/3.0.0-SNAPSHOT/hbase-shaded-server-3.0.0-SNAPSHOT.pom dependency:tree
...
[INFO] +- org.apache.hbase:hbase-resource-bundle:jar:3.0.0-SNAPSHOT:compile (optional)
[INFO] +- log4j:log4j:jar:1.2.17:compile
[INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.24:compile (optional)
[INFO] | \- org.slf4j:slf4j-api:jar:1.7.24:compile
[INFO] \- junit:junit:jar:4.12:compile
[INFO] \- org.hamcrest:hamcrest-core:jar:1.3:test
{noformat}
Patch on top of 8a800c3f196fcbc3ed63f0967025c1779c43d486
{noformat}
$ mvn clean -Dtest=noUnitTests -pl hbase-shaded/hbase-shaded-check-invariants -am -Prelease verify
...
[INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ hbase-shaded-check-invariants ---
[INFO] Artifact looks correct: 'hbase-shaded-client-3.0.0-SNAPSHOT.jar'
[INFO] Artifact looks correct: 'hbase-shaded-mapreduce-3.0.0-SNAPSHOT.jar'
{noformat}
--Patch on top of 8a800c3f196fcbc3ed63f0967025c1779c43d486--
*Edit: Ignore this output. I ran this directly after previous command assuming it was updating jars in my repo. But it wasn't, since it's 'verify' and not 'install'.*
{noformat}
$ mvn -f ~/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/3.0.0-SNAPSHOT/hbase-shaded-mapreduce-3.0.0-SNAPSHOT.pom dependency:tree
...
[INFO] +- org.apache.hbase:hbase-resource-bundle:jar:3.0.0-SNAPSHOT:compile (optional)
[INFO] +- log4j:log4j:jar:1.2.17:compile
[INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.24:compile (optional)
[INFO] \- junit:junit:jar:4.12:compile
[INFO] \- org.hamcrest:hamcrest-core:jar:1.3:test
{noformat}
I haven't tested the jar on live cluster yet. But in the process to do so.
was (Author: appy):
So to make sure that the change is orthogonal to invariant failures happening on current master, i ran the tests first on master hash 8a800c3f196fcbc3ed63f0967025c1779c43d486 (aug 31) and then with the patch. Here are the outputs.
Master @8a800c3f196fcbc3ed63f0967025c1779c43d486
{noformat}
$ mvn clean -Dtest=noUnitTests -pl hbase-shaded/hbase-shaded-check-invariants -am -Prelease verify
...
[INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ hbase-shaded-check-invariants ---
[INFO] Artifact looks correct: 'hbase-shaded-server-3.0.0-SNAPSHOT.jar'
[INFO] Artifact looks correct: 'hbase-shaded-client-3.0.0-SNAPSHOT.jar'
{noformat}
Master @8a800c3f196fcbc3ed63f0967025c1779c43d486
{noformat}
$ mvn -f ~/.m2/repository/org/apache/hbase/hbase-shaded-server/3.0.0-SNAPSHOT/hbase-shaded-server-3.0.0-SNAPSHOT.pom dependency:tree
...
[INFO] +- org.apache.hbase:hbase-resource-bundle:jar:3.0.0-SNAPSHOT:compile (optional)
[INFO] +- log4j:log4j:jar:1.2.17:compile
[INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.24:compile (optional)
[INFO] | \- org.slf4j:slf4j-api:jar:1.7.24:compile
[INFO] \- junit:junit:jar:4.12:compile
[INFO] \- org.hamcrest:hamcrest-core:jar:1.3:test
{noformat}
Patch on top of 8a800c3f196fcbc3ed63f0967025c1779c43d486
{noformat}
$ mvn clean -Dtest=noUnitTests -pl hbase-shaded/hbase-shaded-check-invariants -am -Prelease verify
...
[INFO] --- exec-maven-plugin:1.6.0:exec (check-jar-contents) @ hbase-shaded-check-invariants ---
[INFO] Artifact looks correct: 'hbase-shaded-client-3.0.0-SNAPSHOT.jar'
[INFO] Artifact looks correct: 'hbase-shaded-mapreduce-3.0.0-SNAPSHOT.jar'
{noformat}
Patch on top of 8a800c3f196fcbc3ed63f0967025c1779c43d486
{noformat}
$ mvn -f ~/.m2/repository/org/apache/hbase/hbase-shaded-mapreduce/3.0.0-SNAPSHOT/hbase-shaded-mapreduce-3.0.0-SNAPSHOT.pom dependency:tree
...
[INFO] +- org.apache.hbase:hbase-resource-bundle:jar:3.0.0-SNAPSHOT:compile (optional)
[INFO] +- log4j:log4j:jar:1.2.17:compile
[INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.24:compile (optional)
[INFO] \- junit:junit:jar:4.12:compile
[INFO] \- org.hamcrest:hamcrest-core:jar:1.3:test
{noformat}
I haven't tested the jar on live cluster yet. But in the process to do so.
> Need a shaded hbase-mapreduce module
> ------------------------------------
>
> Key: HBASE-18697
> URL: https://issues.apache.org/jira/browse/HBASE-18697
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Reporter: Duo Zhang
> Assignee: Appy
> Fix For: 3.0.0, 2.0.0-alpha-3
>
> Attachments: HBASE-18697.master.001.patch, HBASE-18697.master.002.patch, HBASE-18697.master.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)