You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/16 17:21:30 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2090: Remove doc hidden from GenericColumnReader
tustvold opened a new pull request, #2090:
URL: https://github.com/apache/arrow-rs/pull/2090
Currently the lack of docs makes it hard to determine how to use `ColumnReaderImpl` - see [here](https://docs.rs/parquet/latest/parquet/column/reader/type.ColumnReaderImpl.html).
The decision was initially made to hide these docs to allow us to evolve the API, however, I think it makes sense to unhide this API because:
* It should be relatively static now
* As ColumnLevelDecoderImpl, etc... are still private, this change does not impact our ability to make breaking changes to them
* We are making more frequent breaking releases than we were at the time this change was made
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2090: Remove doc hidden from GenericColumnReader
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2090:
URL: https://github.com/apache/arrow-rs/pull/2090#discussion_r922702126
##########
parquet/src/arrow/record_reader/mod.rs:
##########
@@ -45,7 +45,6 @@ pub(crate) const MIN_BATCH_SIZE: usize = 1024;
pub type RecordReader<T> =
GenericRecordReader<ScalarBuffer<<T as DataType>::T>, ColumnValueDecoderImpl<T>>;
-#[doc(hidden)]
Review Comment:
Drive by cleanup, this module is private and so there is no user-facing change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2090: Remove doc hidden from GenericColumnReader
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2090:
URL: https://github.com/apache/arrow-rs/pull/2090#issuecomment-1186273194
Benchmark runs are scheduled for baseline = 1738a90ec844d24240059ec532ed5af3979b8fdb and contender = 13adaa7c5a6179267124e79a79b1cc7b8976d9a5. 13adaa7c5a6179267124e79a79b1cc7b8976d9a5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b4daac7929df4e76b1f295ccaf6a8491...ba81095fcc6e4823a4b745343401fd7b/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fec9a2e816d5421fad168857dac09a18...e1ba31e189c8435bab70343475f588c5/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/25691e95de744a3cbb20a07115ae6e79...a0867118a84e4592895602aa9ec4cdc4/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7e5cbc0fa462498ca3b65262c844ecaf...af60a705f8e34582a2ebf71e3e3d4f31/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2090: Remove doc hidden from GenericColumnReader
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2090:
URL: https://github.com/apache/arrow-rs/pull/2090#issuecomment-1186249184
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2090?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2090](https://codecov.io/gh/apache/arrow-rs/pull/2090?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (707d472) into [master](https://codecov.io/gh/apache/arrow-rs/commit/a6379fe9818de3133a80700b7b8d6d9d59b29e37?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6379fe) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2090 +/- ##
==========================================
- Coverage 83.70% 83.70% -0.01%
==========================================
Files 224 224
Lines 58967 58967
==========================================
- Hits 49360 49358 -2
- Misses 9607 9609 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2090?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/arrow/record\_reader/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/2090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvcmVjb3JkX3JlYWRlci9tb2QucnM=) | `89.17% <ø> (ø)` | |
| [parquet/src/column/reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/2090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvY29sdW1uL3JlYWRlci5ycw==) | `62.00% <ø> (ø)` | |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/2090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `64.05% <0.00%> (-0.36%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/2090/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.75% <0.00%> (-0.23%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2090?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2090?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a6379fe...707d472](https://codecov.io/gh/apache/arrow-rs/pull/2090?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2090: Remove doc hidden from GenericColumnReader
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2090:
URL: https://github.com/apache/arrow-rs/pull/2090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org