You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Laffery (via GitHub)" <gi...@apache.org> on 2025/07/17 09:10:34 UTC

[PR] Chore/angular v20 [flink]

Laffery opened a new pull request, #26805:
URL: https://github.com/apache/flink/pull/26805

   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Angular framework and NG-ZORRO both have released their stable v19 versions. It is a good time to bump them to the latest.
   
   ## Brief change log
   
   - update frontend framework `angular` and `ng-zorro-antd` to v20
   - migrate angular builder to `application` (which is default since v19)
   - remove redundant `standalone:true` (which is default since v19)
   - remove deprecated APIs in ng-zorro-antd v20
   - move utility function `typeDefinition` to public-api
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follow [the conventions for tests defined in our code quality guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38044][runtime-web] update angular to v20 [flink]

Posted by "Laffery (via GitHub)" <gi...@apache.org>.
Laffery commented on PR #26805:
URL: https://github.com/apache/flink/pull/26805#issuecomment-3085912624

   @davidradl Oh yes the supported node version of angular v20 had changed to `^20.19.0 || ^22.12.0 || >=24.0.0` and the current version of nodejs is `v22.11.0`
   
   I just pushed a commit to update the version of nodejs to v22 LTS `v22.16.0`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38044][runtime-web] update angular to v20 [flink]

Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong merged PR #26805:
URL: https://github.com/apache/flink/pull/26805


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38044][runtime-web] update angular to v20 [flink]

Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong commented on PR #26805:
URL: https://github.com/apache/flink/pull/26805#issuecomment-3135082198

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38044][runtime-web] update angular to v20 [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26805:
URL: https://github.com/apache/flink/pull/26805#issuecomment-3083287578

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "29747953ee449a10fb293ac039ff94dc21764174",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "29747953ee449a10fb293ac039ff94dc21764174",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 29747953ee449a10fb293ac039ff94dc21764174 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38044][runtime-web] update angular to v20 [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #26805:
URL: https://github.com/apache/flink/pull/26805#issuecomment-3084532180

   @Laffery Thanks for this update. I notice the CI is failing with errors that seems related to the change. 
   Unsupported engine {
   09:47:19.352 [INFO] npm warn EBADENGINE   package: '@angular-devkit/schematics@20.1.1',
   09:47:19.352 [INFO] npm warn EBADENGINE   required: {
   09:47:19.352 [INFO] npm warn EBADENGINE     node: '^20.19.0 || ^22.12.0 || >=24.0.0',
   09:47:19.352 [INFO] npm warn EBADENGINE     npm: '^6.11.0 || ^7.5.6 || >=8.0.0',
   09:47:19.352 [INFO] npm warn EBADENGINE     yarn: '>= 1.13.0'
   09:47:19.352 [INFO] npm warn EBADENGINE   },
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38044][runtime-web] update angular to v20 [flink]

Posted by "Laffery (via GitHub)" <gi...@apache.org>.
Laffery commented on PR #26805:
URL: https://github.com/apache/flink/pull/26805#issuecomment-3135095940

   @simplejason Could you please take a review on this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38044][runtime-web] update angular to v20 [flink]

Posted by "Laffery (via GitHub)" <gi...@apache.org>.
Laffery commented on PR #26805:
URL: https://github.com/apache/flink/pull/26805#issuecomment-3105883287

   hi @davidradl, I had fix the issues mentioned, could you please take a look again on this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38044][runtime-web] update angular to v20 [flink]

Posted by "Laffery (via GitHub)" <gi...@apache.org>.
Laffery commented on PR #26805:
URL: https://github.com/apache/flink/pull/26805#issuecomment-3085919015

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-38044][runtime-web] update angular to v20 [flink]

Posted by "Laffery (via GitHub)" <gi...@apache.org>.
Laffery commented on PR #26805:
URL: https://github.com/apache/flink/pull/26805#issuecomment-3141808532

   It seems that the previous CI errors were caused by the `@angular/build:application` builder in the angular.json, I had reverted the builder and it worked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org