You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/12 13:35:57 UTC
[GitHub] [airflow] tomsej opened a new pull request, #25689: Bump cattrs version
tomsej opened a new pull request, #25689:
URL: https://github.com/apache/airflow/pull/25689
related: #24421
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213297715
Ah noo.... numpy==1.19.4 :...... This is strange.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25689:
URL: https://github.com/apache/airflow/pull/25689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213316605
Yeah. Lookiung at it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213371793
Ok. I merged the fix and rebased your PR on top @tomsej - let's see :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tomsej commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
tomsej commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213451053
@potiuk thanks a lot, I really appreciate it! It failed on binding address for Trino:
``` ERROR: for airflow-integration-postgres_trino_1 Cannot start service trino: driver failed programming external connectivity on endpoint airflow-integration-postgres_trino_1 (50f5ffd5c1adb15ff3699b0b430ad1b8ae39296afe40f7cb5d97eaae97dc58ad): Error starting userland proxy: listen tcp4 0.0.0.0:38080: bind: address already in use```
Do I need to rerun the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213349186
Fix here https://github.com/apache/airflow/pull/25697 - once it gets green and get merged please rebase @tomsej :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213281813
> #56 144.0 error: Command "gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DNPY_INTERNAL_BUILD=1 -DHAVE_NPY_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE=1 -D_LARGEFILE64_SOURCE=1 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/umath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Inumpy/core/include -Ibuild/src.linux-x86_64-3.10/numpy/core/include/numpy -Inumpy/core/src/common -Inumpy/core/src -Inumpy/core -Inumpy/core/src/npymath -Inumpy/core/src/multiarray -Inumpy/core/src/umath -Inumpy/core/src/npysort -I/usr/local/include/python3.10 -Ibuild/src.linux-x86_64-3.10/numpy/core/src/common -Ibuild/src.linux-x86_64-3.10/numpy/core/src/npymath -c build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.c -o build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.10/numpy/core/src/multiarray/scalartypes.o -MMD -MF build/temp.linux-x86_64-3.10/build/src.linux-x86_64-3.
10/numpy/core/src/multiarray/scalartypes.o.d -std=c99" failed with exit status 1
Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213285335
Hmm, recent versions do, but we tried to pull in numpy==1.19.4, but that is not what's in any of the constraint files https://github.com/apache/airflow/blob/constraints-main/constraints-3.10.txt -- any idea why that might be @potiuk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tomsej commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
tomsej commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213308342
I do not think that is the case. Seems some other builds are also failing - https://github.com/apache/airflow/runs/7806805101?check_suite_focus=true#step:13:19601. I cannot investigate since I am not by the computer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tomsej commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
tomsej commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213222368
> Sounds good to me, but haven't checked anything in detail here.
>
> Have you checked the changelog of cattrs to see if anything is likely to break for us?
Honestly, it is hard to say. Previously, it broke a lineage (#16172), but it should be fixed in https://github.com/python-attrs/cattrs/issues/151. There is also a new validation mode https://cattrs.readthedocs.io/en/latest/validation.html but I do not think it should break anything.
Build is failing but it seems to be unrelated to my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213293247
> Build error is caused by trying to build numpy on 3.10 (numpy still doesn't have a wheel for 3.10?!)
Bumping cattrs unblocked numpy to be bumped to 1,23.* (from 1.22.4) which apparently has problem with 3,10. I thin k 1.22.4 also does not support 3.10 fully - but it did not have a detection of that :shrug:
numpy is only needed in oracle provider it seems (BTW. we should get rid of it - I believe it is only needed there to do detection
The solution @romsej will be to change in https://github.com/apache/airflow/blob/main/airflow/providers/oracle/provider.yaml
```
dependencies:
- numpy
```
to:
```
dependencies:
- numpy;python_version<"3.10"
- numpy<1.23;python_version>="3.10"
```
But I will try to get rid of it completely in parallel anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213554031
I re-run it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tomsej commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
tomsej commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213334362
Ohh, thanks a lot! Let me know if I can help...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213327731
This is a more complex issue - looks like `pip resolver` started to downgrade our pyarrow for 3.10 which triggered downgrading numpy :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213554219
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25689: Bump cattrs version
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25689:
URL: https://github.com/apache/airflow/pull/25689#issuecomment-1213117780
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org