You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2019/07/25 00:36:19 UTC
[incubator-pinot] branch master updated: Enable periodic rebalance
as a temporary work-around for the Helix issue (#4459)
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1d45f87 Enable periodic rebalance as a temporary work-around for the Helix issue (#4459)
1d45f87 is described below
commit 1d45f87be735327ddc6273df8d561d123af9b301
Author: Xiaotian (Jackie) Jiang <17...@users.noreply.github.com>
AuthorDate: Wed Jul 24 17:36:13 2019 -0700
Enable periodic rebalance as a temporary work-around for the Helix issue (#4459)
Helix issue: https://github.com/apache/helix/issues/331
---
.../org/apache/pinot/controller/helix/ControllerTest.java | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java b/pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java
index 4c5ff81..4d49192 100644
--- a/pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java
+++ b/pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java
@@ -28,6 +28,7 @@ import java.io.InputStreamReader;
import java.io.OutputStreamWriter;
import java.net.HttpURLConnection;
import java.net.URL;
+import java.util.Collections;
import org.apache.commons.httpclient.HttpClient;
import org.apache.commons.httpclient.methods.PostMethod;
import org.apache.commons.httpclient.methods.PutMethod;
@@ -39,6 +40,9 @@ import org.apache.commons.io.IOUtils;
import org.apache.helix.HelixAdmin;
import org.apache.helix.HelixManager;
import org.apache.helix.ZNRecord;
+import org.apache.helix.model.ClusterConfig;
+import org.apache.helix.model.HelixConfigScope;
+import org.apache.helix.model.builder.HelixConfigScopeBuilder;
import org.apache.helix.store.zk.ZkHelixPropertyStore;
import org.apache.pinot.common.data.DimensionFieldSpec;
import org.apache.pinot.common.data.FieldSpec;
@@ -124,6 +128,13 @@ public abstract class ControllerTest {
case PINOT_ONLY:
_helixAdmin = _helixResourceManager.getHelixAdmin();
_propertyStore = _helixResourceManager.getPropertyStore();
+
+ // TODO: Enable periodic rebalance per 10 seconds as a temporary work-around for the Helix issue:
+ // https://github.com/apache/helix/issues/331. Remove this after Helix fixing the issue.
+ _helixAdmin.setConfig(
+ new HelixConfigScopeBuilder(HelixConfigScope.ConfigScopeProperty.CLUSTER).forCluster(getHelixClusterName())
+ .build(),
+ Collections.singletonMap(ClusterConfig.ClusterConfigProperty.REBALANCE_TIMER_PERIOD.name(), "10000"));
break;
case HELIX_ONLY:
_helixAdmin = _helixManager.getClusterManagmentTool();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org