You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/21 08:08:19 UTC

[GitHub] [eventmesh] pandaapo opened a new pull request, #3988: [ISSUE #481]Use YAML file to store configuration

pandaapo opened a new pull request, #3988:
URL: https://github.com/apache/eventmesh/pull/3988

   Fixes #481.
   
   ### Motivation
   
   See "Enhancement Request" in [issue](https://github.com/apache/eventmesh/issues/481#issue-959081252).
   
   
   
   ### Modifications
   
   The default config file format keeps `eventmesh.properties`. When user set only config file in yaml format, EventMesh will find it and load it.
   
   
   
   ### Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   - If a feature is not applicable for documentation, explain why?
   - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [eventmesh] pandaapo commented on pull request #3988: [ISSUE #481]Use YAML file to store configuration

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3988:
URL: https://github.com/apache/eventmesh/pull/3988#issuecomment-1556191743

   > Hi @pandaapo This feature has been implemented. You can refer to the specific class org.apache.eventmesh.common.config.FileLoad.
   
   Thanks for your review.
   * You can try its method `FileLoad.YamlFileLoad#getConfig(ConfigInfo)`. Then will can get properties like `aaa ->, bbb -> , ccc -> 3` when the yml content is
   ```
   aaa
     bbb
       ccc: 3
   ```
   
   * Current code will never load eventmesh.yaml. Because the call stack logic in starting up with standalone mode always use  `PropertiesFileLoad`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #481]Use YAML file to store configuration (eventmesh)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3988:
URL: https://github.com/apache/eventmesh/pull/3988#issuecomment-2067750692

   It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
   
   If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #481]Use YAML file to store configuration (eventmesh)

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #3988:
URL: https://github.com/apache/eventmesh/pull/3988#discussion_r1256079492


##########
eventmesh-runtime/conf/eventmesh.yml:
##########
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+eventMesh:
+  server:
+    ############################### eventMesh-runtime ENV #################################
+    idc: DEFAULT
+    env: PRD
+    provide:
+      protocols: HTTP,TCP,GRPC
+    cluster: COMMON
+    name: EVENTMESH-runtime
+    http:
+      port: 10105
+      # flow control, include the global level and session level
+      msgReqnumPerSecond: 15000
+    grpc:
+      port: 10205
+    ########################## eventMesh tcp configuration ############################
+    tcp:
+      enabled: true
+      port: 10002
+      readerIdleSeconds: 120
+      writerIdleSeconds: 120
+      allIdleSeconds: 120
+      clientMaxNum: 10000
+      # client isolation time if the message send failure
+      pushFailIsolateTimeInMills: 30000
+      # rebalance internal
+      RebalanceIntervalInMills: 30000
+      # flow control, include the global level and session level
+      msgReqnumPerSecond: 15000
+      taskHandleExecutorPoolSize: 8
+    session:
+      # session expire time about client
+      expiredInMills: 60000
+      # flow control, include the global level and session level
+      upstreamBufferSize: 20
+    # for single event publish, maximum size allowed per event
+    maxEventSize: 1000
+    # for batch event publish, maximum number of events allowed in one batch
+    maxEventBatchSize: 10
+    global:
+      # thread number about global scheduler
+      scheduler: 5
+    # retry
+    retry:
+      async:
+        pushRetryTimes: 3
+        pushRetryDelayInMills: 500
+      sync:
+        pushRetryTimes: 3
+        pushRetryDelayInMills: 500
+      pushRetryQueueSize: 10000
+    # admin
+    admin:
+      http:
+        port: 10106
+    # registry
+    registry:
+      registerIntervalInMills: 10000
+      fetchRegistryAddrIntervalInMills: 20000
+#    # auto-ack
+#    defibus:
+#      client:
+#        consumeTimeoutInMin: 5
+    # sleep interval between closing client of different group in server graceful shutdown
+    gracefulShutdown:
+      sleepIntervalInMills: 1000
+    rebalanceRedirect:
+      sleepIntervalInMills: 200
+    # ip address blacklist
+    blacklist:
+      ipv4: 0.0.0.0/8,127.0.0.0/8,169.254.0.0/16,255.255.255.255/32
+      ipv6: ::/128,::1/128,ff00::/8
+    security:
+      enabled: false
+    trace:
+      enabled: false
+  sysid: 0000
+  # connector plugin
+  connector:
+    plugin:
+      type: standalone
+  # storage plugin
+  storage:
+    plugin:
+      type: standalone
+  # security plugin
+  security:
+    plugin:
+      type: security
+    validation:
+      type:
+        token: false
+    publickey: ''
+  # registry plugin
+  registry:
+    plugin:
+      enabled: false
+      type: nacos
+      server-addr: 127.0.0.1:8848
+      username: nacos
+      password: nacos
+  # metrics plugin, if you have multiple plugin, you can use ',' to split
+  metrics:
+    plugin: prometheus
+  # trace plugin
+  trace:
+    plugin: zipkin
+  # webhook
+  webHook:
+    admin:
+      # Start webhook admin service
+      start: true
+    # Webhook event configuration storage mode. Currently, only file and Nacos are supported
+    operationMode: file
+    fileMode:
+      # The file storage path of the file storage mode. If ${eventmeshhome} is written, it is in the eventmesh root directory
+      filePath: ${eventMeshHome}/webhook
+    # Nacos storage mode, and the configuration naming rule is eventmesh webHook. nacosMode. {nacos native configuration key} please see the specific configuration [nacos github api](https://github.com/alibaba/nacos/blob/develop/api/src/main/java/com/alibaba/nacos/api/SystemPropertyKeyConst.java)
+    ## Address of Nacos
+    nacosMode:
+      serverAddr: 127.0.0.1:8848
+    # Webhook eventcloud sending mode. And eventmesh connector. plugin. The type configuration is the same
+    producer:
+      storage: standalone

Review Comment:
   Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #481] Use YAML file to store configuration (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #3988:
URL: https://github.com/apache/eventmesh/pull/3988#issuecomment-2074485379

   Any progress we can make here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] codecov[bot] commented on pull request #3988: [ISSUE #481]Use YAML file to store configuration

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3988:
URL: https://github.com/apache/eventmesh/pull/3988#issuecomment-1562473910

   ## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#3988](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bd8cde0) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/0ce8d57e6a87890354fdc0643f06aae4acb6cc41?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0ce8d57) will **decrease** coverage by `0.04%`.
   > The diff coverage is `30.66%`.
   
   > :exclamation: Current head bd8cde0 differs from pull request most recent head 2ececd2. Consider uploading reports for the commit 2ececd2 to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3988      +/-   ##
   ============================================
   - Coverage     14.24%   14.20%   -0.04%     
   - Complexity     1320     1328       +8     
   ============================================
     Files           579      583       +4     
     Lines         28967    29006      +39     
     Branches       2802     2796       -6     
   ============================================
   - Hits           4125     4121       -4     
   - Misses        24450    24494      +44     
   + Partials        392      391       -1     
   ```
   
   
   | [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...a/org/apache/eventmesh/common/utils/FileUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9GaWxlVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...org/apache/eventmesh/common/file/YamlFileLoad.java](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9maWxlL1lhbWxGaWxlTG9hZC5qYXZh) | `4.54% <4.54%> (ø)` | |
   | [.../apache/eventmesh/common/config/ConfigService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29uZmlnU2VydmljZS5qYXZh) | `42.35% <16.66%> (-2.10%)` | :arrow_down: |
   | [...ava/org/apache/eventmesh/common/file/FileLoad.java](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9maWxlL0ZpbGVMb2FkLmphdmE=) | `44.44% <44.44%> (ø)` | |
   | [...org/apache/eventmesh/common/file/BaseFileLoad.java](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9maWxlL0Jhc2VGaWxlTG9hZC5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [...ache/eventmesh/common/file/PropertiesFileLoad.java](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9maWxlL1Byb3BlcnRpZXNGaWxlTG9hZC5qYXZh) | `100.00% <100.00%> (ø)` | |
   
   ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3988/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #481]Use YAML file to store configuration (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #3988:
URL: https://github.com/apache/eventmesh/pull/3988#issuecomment-1893618624

   I think we should only use one configuration file, either `eventmesh.yml` or `eventmesh.properties`. Having both concurrently would pose difficulties in maintenance.
   
   Considering that connectors all use YAML configuration files, the presence of `eventmesh.properties` feels inconsistent, since it is one of the few properties files in EventMesh. Therefore, my preference would be to standardize the use of YAML files.
   
   In our project, we currently have both `.yml` and `.yaml` files, and both file extensions are valid. However, it would be necessary to choose one for consistency. Although `.yaml` is a more standard and compliant file extension compared to `.yml`, the majority of our project uses `.yml`. Hence, I recommend standardizing on the `.yml` extension (except for `.asf.yaml`).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] mxsm commented on pull request #3988: [ISSUE #481]Use YAML file to store configuration

Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on PR #3988:
URL: https://github.com/apache/eventmesh/pull/3988#issuecomment-1556186241

   Hi @pandaapo  This feature has been implemented. You can refer to the specific class org.apache.eventmesh.common.config.FileLoad.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #481]Use YAML file to store configuration (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #3988:
URL: https://github.com/apache/eventmesh/pull/3988#discussion_r1253879868


##########
eventmesh-runtime/conf/eventmesh.yml:
##########
@@ -0,0 +1,141 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+eventMesh:
+  server:
+    ############################### eventMesh-runtime ENV #################################
+    idc: DEFAULT
+    env: PRD
+    provide:
+      protocols: HTTP,TCP,GRPC
+    cluster: COMMON
+    name: EVENTMESH-runtime
+    http:
+      port: 10105
+      # flow control, include the global level and session level
+      msgReqnumPerSecond: 15000
+    grpc:
+      port: 10205
+    ########################## eventMesh tcp configuration ############################
+    tcp:
+      enabled: true
+      port: 10002
+      readerIdleSeconds: 120
+      writerIdleSeconds: 120
+      allIdleSeconds: 120
+      clientMaxNum: 10000
+      # client isolation time if the message send failure
+      pushFailIsolateTimeInMills: 30000
+      # rebalance internal
+      RebalanceIntervalInMills: 30000
+      # flow control, include the global level and session level
+      msgReqnumPerSecond: 15000
+      taskHandleExecutorPoolSize: 8
+    session:
+      # session expire time about client
+      expiredInMills: 60000
+      # flow control, include the global level and session level
+      upstreamBufferSize: 20
+    # for single event publish, maximum size allowed per event
+    maxEventSize: 1000
+    # for batch event publish, maximum number of events allowed in one batch
+    maxEventBatchSize: 10
+    global:
+      # thread number about global scheduler
+      scheduler: 5
+    # retry
+    retry:
+      async:
+        pushRetryTimes: 3
+        pushRetryDelayInMills: 500
+      sync:
+        pushRetryTimes: 3
+        pushRetryDelayInMills: 500
+      pushRetryQueueSize: 10000
+    # admin
+    admin:
+      http:
+        port: 10106
+    # registry
+    registry:
+      registerIntervalInMills: 10000
+      fetchRegistryAddrIntervalInMills: 20000
+#    # auto-ack
+#    defibus:
+#      client:
+#        consumeTimeoutInMin: 5
+    # sleep interval between closing client of different group in server graceful shutdown
+    gracefulShutdown:
+      sleepIntervalInMills: 1000
+    rebalanceRedirect:
+      sleepIntervalInMills: 200
+    # ip address blacklist
+    blacklist:
+      ipv4: 0.0.0.0/8,127.0.0.0/8,169.254.0.0/16,255.255.255.255/32
+      ipv6: ::/128,::1/128,ff00::/8
+    security:
+      enabled: false
+    trace:
+      enabled: false
+  sysid: 0000
+  # connector plugin
+  connector:
+    plugin:
+      type: standalone
+  # storage plugin
+  storage:
+    plugin:
+      type: standalone
+  # security plugin
+  security:
+    plugin:
+      type: security
+    validation:
+      type:
+        token: false
+    publickey: ''
+  # registry plugin
+  registry:
+    plugin:
+      enabled: false
+      type: nacos
+      server-addr: 127.0.0.1:8848
+      username: nacos
+      password: nacos
+  # metrics plugin, if you have multiple plugin, you can use ',' to split
+  metrics:
+    plugin: prometheus
+  # trace plugin
+  trace:
+    plugin: zipkin
+  # webhook
+  webHook:
+    admin:
+      # Start webhook admin service
+      start: true
+    # Webhook event configuration storage mode. Currently, only file and Nacos are supported
+    operationMode: file
+    fileMode:
+      # The file storage path of the file storage mode. If ${eventmeshhome} is written, it is in the eventmesh root directory
+      filePath: ${eventMeshHome}/webhook
+    # Nacos storage mode, and the configuration naming rule is eventmesh webHook. nacosMode. {nacos native configuration key} please see the specific configuration [nacos github api](https://github.com/alibaba/nacos/blob/develop/api/src/main/java/com/alibaba/nacos/api/SystemPropertyKeyConst.java)
+    ## Address of Nacos
+    nacosMode:
+      serverAddr: 127.0.0.1:8848
+    # Webhook eventcloud sending mode. And eventmesh connector. plugin. The type configuration is the same
+    producer:
+      storage: standalone

Review Comment:
   ![image](https://github.com/apache/eventmesh/assets/41445332/99683171-b442-47c2-92e3-24a9f81c9709)
   
   As is seen in https://github.com/apache/eventmesh/issues/4185, According to the original Chinese comments in the git commit history, the existing English comments are misleading. The English translation does not match the meaning of the original Chinese text, which affects understanding.
   
   ```suggestion
       # Webhook CloudEvent sending mode. This property is the same as the eventMesh.storage.plugin.type configuration.
       producer:
         storage: standalone
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #481]Use YAML file to store configuration (eventmesh)

Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3988:
URL: https://github.com/apache/eventmesh/pull/3988#issuecomment-1893652061

   > I think we should only use one configuration file, either `eventmesh.yml` or `eventmesh.properties`. Having both concurrently would pose difficulties in maintenance.
   > 
   > Considering that connectors all use YAML configuration files, the presence of `eventmesh.properties` feels inconsistent, since it is one of the few properties files in EventMesh. Therefore, my preference would be to standardize the use of YAML files.
   > 
   > In our project, we currently have both `.yml` and `.yaml` files, and both file extensions are valid. However, it would be necessary to choose one for consistency. Although `.yaml` is a more standard and compliant file extension compared to `.yml`, the majority of our project uses `.yml`. Hence, I recommend standardizing on the `.yml` extension (except for `.asf.yaml`).
   
   Thanks for your review. But sorry, many of your points I couldn't agree with, and they were even a bit strange to me. No offense, I'm willing to wait for more members of the community to express their views on these points of yours. If there are no objections, I will revise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #481]Use YAML file to store configuration (eventmesh)

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3988:
URL: https://github.com/apache/eventmesh/pull/3988#issuecomment-2067750719

   ## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3988?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `30.66667%` with `52 lines` in your changes are missing coverage. Please review.
   > Project coverage is 14.22%. Comparing base [(`fb144bb`)](https://app.codecov.io/gh/apache/eventmesh/commit/fb144bb1d0d838ef2a4d1cccc2bd7877bd4ab09f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2bb30ef`)](https://app.codecov.io/gh/apache/eventmesh/pull/3988?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 409 commits behind head on master.
   
   > :exclamation: Current head 2bb30ef differs from pull request most recent head 83fb56e. Consider uploading reports for the commit 83fb56e to get more accurate results
   
   | [Files](https://app.codecov.io/gh/apache/eventmesh/pull/3988?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...org/apache/eventmesh/common/file/YamlFileLoad.java](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Ffile%2FYamlFileLoad.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9maWxlL1lhbWxGaWxlTG9hZC5qYXZh) | 4.54% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...a/org/apache/eventmesh/common/utils/FileUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Futils%2FFileUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9GaWxlVXRpbHMuamF2YQ==) | 0.00% | [21 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [.../apache/eventmesh/common/config/ConfigService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Fconfig%2FConfigService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29uZmlnU2VydmljZS5qYXZh) | 16.66% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...ava/org/apache/eventmesh/common/file/FileLoad.java](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Ffile%2FFileLoad.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9maWxlL0ZpbGVMb2FkLmphdmE=) | 44.44% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3988      +/-   ##
   ============================================
   - Coverage     14.22%   14.22%   -0.01%     
     Complexity     1328     1328              
   ============================================
     Files           580      583       +3     
     Lines         28856    29013     +157     
     Branches       2792     2810      +18     
   ============================================
   + Hits           4105     4127      +22     
   - Misses        24361    24494     +133     
   - Partials        390      392       +2     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/3988?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org