You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/07/20 10:16:48 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #2915: Laveraging quarkus-security
JiriOndrusek opened a new pull request #2915:
URL: https://github.com/apache/camel-quarkus/pull/2915
fixes https://github.com/apache/camel-quarkus/issues/2005
Quarkus can only register boucyCastleProvider in current state. So I used it instead of our code and removed duplicate code (which exists in quarkus).
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #2915: Laveraging quarkus-security
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #2915:
URL: https://github.com/apache/camel-quarkus/pull/2915#issuecomment-883336289
@ppalaga I'm thinking about moving some registrations for reflection into quarkus-security, because some similar stuff is already there (see https://github.com/quarkusio/quarkus/blob/main/extensions/security/deployment/src/main/java/io/quarkus/security/deployment/SecurityProcessor.java#L149)
But I'm not sure whether it will be accepted. If some of that code makes it into qaurkus, it should be removed from here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2915: Laveraging quarkus-security
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2915:
URL: https://github.com/apache/camel-quarkus/pull/2915#issuecomment-884003307
> @ppalaga I'm thinking about moving some registrations for reflection into quarkus-security, because some similar stuff is already there (see https://github.com/quarkusio/quarkus/blob/main/extensions/security/deployment/src/main/java/io/quarkus/security/deployment/SecurityProcessor.java#L149)
> But I'm not sure whether it will be accepted. If some of that code makes it into qaurkus, it should be removed from here...
+1, could you please file an issue on our side so that we don't forget about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #2915: Laveraging quarkus-security
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #2915:
URL: https://github.com/apache/camel-quarkus/pull/2915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #2915: Laveraging quarkus-security
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #2915:
URL: https://github.com/apache/camel-quarkus/pull/2915#issuecomment-884013760
Issue is created as https://github.com/apache/camel-quarkus/issues/2922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org