You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/10/29 10:32:55 UTC
[GitHub] [logging-log4j2] bwoester opened a new pull request #594: Log4 j2 3168 overwritten rotated logs
bwoester opened a new pull request #594:
URL: https://github.com/apache/logging-log4j2/pull/594
This fixes an issue in the rolling file appender. The increment counter in the filePattern didn't work if the filenames contained regex characters. In our case it was the '+' character introduced by the timezone in a timestamp (app-20211029T123000+0200.%i.log), that caused filenames to be missed by the `getEligibleFiles` method.
The fix quotes the parts of the filenames that are not meant to be treated as regex.
I think this is the actual cause for JIRA ticket https://issues.apache.org/jira/browse/LOG4J2-3168 not the compression mentioned in the ticket.
The first commit in this PR has to be reverted before merging, I kept it for now in case there's more work to be done on the PR.
Please let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] bwoester commented on pull request #594: Log4 j2 3168 overwritten rotated logs
Posted by GitBox <gi...@apache.org>.
bwoester commented on pull request #594:
URL: https://github.com/apache/logging-log4j2/pull/594#issuecomment-974809226
Tanks a lot! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #594: Log4 j2 3168 overwritten rotated logs
Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #594:
URL: https://github.com/apache/logging-log4j2/pull/594#issuecomment-974730450
Because of the 2 bad files I had to manually create a patch and apply it, but this patch has been applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] bwoester commented on pull request #594: Log4 j2 3168 overwritten rotated logs
Posted by GitBox <gi...@apache.org>.
bwoester commented on pull request #594:
URL: https://github.com/apache/logging-log4j2/pull/594#issuecomment-974809226
Tanks a lot! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #594: Log4 j2 3168 overwritten rotated logs
Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #594:
URL: https://github.com/apache/logging-log4j2/pull/594#issuecomment-974730450
Because of the 2 bad files I had to manually create a patch and apply it, but this patch has been applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers closed pull request #594: Log4 j2 3168 overwritten rotated logs
Posted by GitBox <gi...@apache.org>.
rgoers closed pull request #594:
URL: https://github.com/apache/logging-log4j2/pull/594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers closed pull request #594: Log4 j2 3168 overwritten rotated logs
Posted by GitBox <gi...@apache.org>.
rgoers closed pull request #594:
URL: https://github.com/apache/logging-log4j2/pull/594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org