You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/07 10:31:52 UTC
Review Request 39076: CMake: Added ability of Windows builds to
include protobuf headers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39076/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Added ability of Windows builds to include protobuf headers.
Diffs
-----
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af
Diff: https://reviews.apache.org/r/39076/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39076: CMake: Added ability of Windows builds to
include protobuf headers.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39076/#review101750
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39019, 39076]
All tests passed.
- Mesos ReviewBot
On Oct. 7, 2015, 8:31 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39076/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 8:31 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Added ability of Windows builds to include protobuf headers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af
>
> Diff: https://reviews.apache.org/r/39076/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39076: CMake: Added ability of Windows builds to
include protobuf headers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39076/#review101785
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (lines 105 - 109)
<https://reviews.apache.org/r/39076/#comment159275>
Nit: Can you change this to a if-else (minus the elseif)?
- Joseph Wu
On Oct. 7, 2015, 1:31 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39076/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 1:31 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Added ability of Windows builds to include protobuf headers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af
>
> Diff: https://reviews.apache.org/r/39076/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39076: CMake: Added ability of Windows builds to
include protobuf headers.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39076/#review102402
-----------------------------------------------------------
LGTM.
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (lines 62 - 64)
<https://reviews.apache.org/r/39076/#comment160034>
micro-nit: shall the values be aligned here and below (in the else branch)?
- Artem Harutyunyan
On Oct. 12, 2015, 10:51 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39076/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 10:51 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Added ability of Windows builds to include protobuf headers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af
>
> Diff: https://reviews.apache.org/r/39076/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39076: CMake: Added ability of Windows builds to
include protobuf headers.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39076/#review102603
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (line 109)
<https://reviews.apache.org/r/39076/#comment160333>
missing space after `endif`
- Joris Van Remoortere
On Oct. 14, 2015, 11:47 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39076/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 11:47 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: Added ability of Windows builds to include protobuf headers.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af
>
> Diff: https://reviews.apache.org/r/39076/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39076: CMake: Added ability of Windows builds to
include protobuf headers.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39076/
-----------------------------------------------------------
(Updated Oct. 14, 2015, 11:47 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Added ability of Windows builds to include protobuf headers.
Diffs
-----
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af
Diff: https://reviews.apache.org/r/39076/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39076: CMake: Added ability of Windows builds to
include protobuf headers.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39076/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 6:25 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Added ability of Windows builds to include protobuf headers.
Diffs (updated)
-----
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af
Diff: https://reviews.apache.org/r/39076/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39076: CMake: Added ability of Windows builds to
include protobuf headers.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39076/
-----------------------------------------------------------
(Updated Oct. 12, 2015, 5:51 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Added ability of Windows builds to include protobuf headers.
Diffs
-----
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af
Diff: https://reviews.apache.org/r/39076/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 39076: CMake: Added ability of Windows builds to
include protobuf headers.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39076/
-----------------------------------------------------------
(Updated Oct. 10, 2015, 4:25 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
CMake: Added ability of Windows builds to include protobuf headers.
Diffs (updated)
-----
3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake ee1c74d31e28136bf289f4100d79a8ce568cd3af
Diff: https://reviews.apache.org/r/39076/diff/
Testing
-------
Thanks,
Alex Clemmer