You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/06/02 10:44:32 UTC
[GitHub] [cassandra-builds] snazy opened a new pull request #22: CASSANDRA-15835 Update Docker image w/ JAVA8_HOME via ENV
snazy opened a new pull request #22:
URL: https://github.com/apache/cassandra-builds/pull/22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] michaelsembwever commented on pull request #22: CASSANDRA-15835 Update Docker image w/ JAVA8_HOME via ENV
Posted by GitBox <gi...@apache.org>.
michaelsembwever commented on pull request #22:
URL: https://github.com/apache/cassandra-builds/pull/22#issuecomment-638029154
> I published nastra/cassandra-testing-ubuntu1910-java11:20200603 and nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603 with your changes @snazy
Can we follow up (separately) how we go about deploying these images (and to where).
I'm thinking that cassandra-builds should have its "Building packages" instructions put into a build script and put into ASF CI, and investigate if we can CD those builds into dockerhub…
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] snazy merged pull request #22: CASSANDRA-15835 Update Docker image w/ JAVA8_HOME via ENV
Posted by GitBox <gi...@apache.org>.
snazy merged pull request #22:
URL: https://github.com/apache/cassandra-builds/pull/22
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] nastra commented on pull request #22: CASSANDRA-15835 Update Docker image w/ JAVA8_HOME via ENV
Posted by GitBox <gi...@apache.org>.
nastra commented on pull request #22:
URL: https://github.com/apache/cassandra-builds/pull/22#issuecomment-638025369
I published `nastra/cassandra-testing-ubuntu1910-java11:20200603` and `nastra/cassandra-testing-ubuntu1910-java11-w-dependencies:20200603` with your changes @snazy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-builds] nastra commented on a change in pull request #22: CASSANDRA-15835 Update Docker image w/ JAVA8_HOME via ENV
Posted by GitBox <gi...@apache.org>.
nastra commented on a change in pull request #22:
URL: https://github.com/apache/cassandra-builds/pull/22#discussion_r434357784
##########
File path: docker/testing/ubuntu18_j11.docker
##########
@@ -80,6 +80,11 @@ RUN echo 'export ANT_HOME=/usr/share/ant' >> /home/cassandra/.bashrc && \
echo 'export JAVA11_HOME=/usr/lib/jvm/java-11-openjdk-amd64' >> /home/cassandra/.bashrc && \
echo 'export JAVA_HOME=$JAVA8_HOME' >> /home/cassandra/.bashrc
+ENV ANT_HOME=/usr/share/ant \
Review comment:
you can't really build this docker image anymore, so not sure we actually need these changes here
##########
File path: docker/testing/ubuntu1810_j11.docker
##########
@@ -80,6 +80,11 @@ RUN echo 'export ANT_HOME=/usr/share/ant' >> /home/cassandra/.bashrc && \
echo 'export JAVA11_HOME=/usr/lib/jvm/java-11-openjdk-amd64' >> /home/cassandra/.bashrc && \
echo 'export JAVA_HOME=$JAVA8_HOME' >> /home/cassandra/.bashrc
+ENV ANT_HOME=/usr/share/ant \
Review comment:
you can't really build this docker image anymore, so not sure we actually need these changes here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org