You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/21 14:59:59 UTC
[GitHub] [skywalking-banyandb] lujiajing1126 opened a new pull request #44: Refactor binary data projection
lujiajing1126 opened a new pull request #44:
URL: https://github.com/apache/skywalking-banyandb/pull/44
Previously, we include `data_binary` in the projection which causes invalid request. The error is reported by the query analyzer becuase every projection field must be a valid field defined in the schema.
However, the dataBinary is indeed a special field in the write entity, so it should equivalently be treated specifically from query side.
This PR intends to refine the query protocol with an additional bool `data_binary` field. After this PR is merged, I will sync this protocol for java client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #44: Refactor binary data projection
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #44:
URL: https://github.com/apache/skywalking-banyandb/pull/44#issuecomment-903202945
@lujiajing1126 pls fix ci failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily merged pull request #44: Refactor binary data projection
Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #44:
URL: https://github.com/apache/skywalking-banyandb/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #44: Refactor binary data projection
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #44:
URL: https://github.com/apache/skywalking-banyandb/pull/44#issuecomment-903206744
> @lujiajing1126 pls fix ci failures
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org