[jira] [Commented] (FLINK-4173) Replace maven-assembly-plugin by maven-shade-plugin in flink-metrics

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424240#comment-15424240 ] 

ASF GitHub Bot commented on FLINK-4173:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2216
  
    Could you recap why do we needs to build fat jars here at all? Simply having the transitive dependencies does not work?


> Replace maven-assembly-plugin by maven-shade-plugin in flink-metrics
> --------------------------------------------------------------------
>
>                 Key: FLINK-4173
>                 URL: https://issues.apache.org/jira/browse/FLINK-4173
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Chesnay Schepler
>            Priority: Minor
>
> The modules {{flink-metrics-dropwizard}}, {{flink-metrics-ganglia}} and {{flink-metrics-graphite}} use the {{maven-assembly-plugin}} to build a fat jar. The resulting fat jar has the suffix {{jar-with-dependencies}}. In order to make the naming consistent with the rest of the system we should create a fat-jar without this suffix.
> Additionally we could replace the {{maven-assembly-plugin}} with the {{maven-shade-plugin}} to make it consistent with the rest of the system.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)