You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/05/16 14:06:50 UTC
[GitHub] [cordova-ios] erisu opened a new pull request #847: breaking: add & use fs-extra w/ fixes
erisu opened a new pull request #847:
URL: https://github.com/apache/cordova-ios/pull/847
### Motivation, Context & Description
* Add `fs-extra` dependency
* Replace `fs` usage with `fs-extra`
* Replace test spec xml generating logic and use pre-made xml test fixtures. Lower the amount of call mocks with actual tool usage for improved testing.
### Testing
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] erisu merged pull request #847: breaking: add & use fs-extra w/ fixes
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #847:
URL: https://github.com/apache/cordova-ios/pull/847
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter commented on pull request #847: breaking: add & use fs-extra w/ fixes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #847:
URL: https://github.com/apache/cordova-ios/pull/847#issuecomment-630523895
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=h1) Report
> Merging [#847](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aae6a86fb5427c99ee2046a1151afc2228a398f5&el=desc) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #847 +/- ##
=======================================
Coverage 74.40% 74.40%
=======================================
Files 13 13
Lines 1821 1821
=======================================
Hits 1355 1355
Misses 466 466
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz) | `71.42% <100.00%> (ø)` | |
| [...in/templates/scripts/cordova/lib/BridgingHeader.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL0JyaWRnaW5nSGVhZGVyLmpz) | `95.45% <100.00%> (ø)` | |
| [bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=) | `73.58% <100.00%> (ø)` | |
| [bin/templates/scripts/cordova/lib/PodsJson.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZHNKc29uLmpz) | `95.04% <100.00%> (ø)` | |
| [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `50.76% <100.00%> (ø)` | |
| [...ates/scripts/cordova/lib/plugman/pluginHandlers.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3BsdWdtYW4vcGx1Z2luSGFuZGxlcnMuanM=) | `90.20% <100.00%> (ø)` | |
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `82.05% <100.00%> (ø)` | |
| [bin/templates/scripts/cordova/lib/projectFile.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3Byb2plY3RGaWxlLmpz) | `94.64% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=footer). Last update [aae6a86...d96a131](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter edited a comment on pull request #847: breaking: add & use fs-extra w/ fixes
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #847:
URL: https://github.com/apache/cordova-ios/pull/847#issuecomment-630523895
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=h1) Report
> Merging [#847](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/aae6a86fb5427c99ee2046a1151afc2228a398f5&el=desc) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #847 +/- ##
=======================================
Coverage 74.40% 74.40%
=======================================
Files 13 13
Lines 1821 1821
=======================================
Hits 1355 1355
Misses 466 466
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz) | `71.42% <100.00%> (ø)` | |
| [...in/templates/scripts/cordova/lib/BridgingHeader.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL0JyaWRnaW5nSGVhZGVyLmpz) | `95.45% <100.00%> (ø)` | |
| [bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=) | `73.58% <100.00%> (ø)` | |
| [bin/templates/scripts/cordova/lib/PodsJson.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZHNKc29uLmpz) | `95.04% <100.00%> (ø)` | |
| [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `50.76% <100.00%> (ø)` | |
| [...ates/scripts/cordova/lib/plugman/pluginHandlers.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3BsdWdtYW4vcGx1Z2luSGFuZGxlcnMuanM=) | `90.20% <100.00%> (ø)` | |
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `82.05% <100.00%> (ø)` | |
| [bin/templates/scripts/cordova/lib/projectFile.js](https://codecov.io/gh/apache/cordova-ios/pull/847/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3Byb2plY3RGaWxlLmpz) | `94.64% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=footer). Last update [aae6a86...d96a131](https://codecov.io/gh/apache/cordova-ios/pull/847?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] timbru31 commented on pull request #847: breaking: add & use fs-extra w/ fixes
Posted by GitBox <gi...@apache.org>.
timbru31 commented on pull request #847:
URL: https://github.com/apache/cordova-ios/pull/847#issuecomment-630922496
> Replace test spec xml generating logic and use pre-made xml test fixtures. Lower the amount of call mocks with actual tool usage for improved testing.
Very nice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org