[GitHub] [incubator-nuttx] masayuki2009 commented on issue #1838: Do we still need IFF_DOWN?

[GitBox <gi...@apache.org>]

masayuki2009 commented on issue #1838:
URL: https://github.com/apache/incubator-nuttx/issues/1838#issuecomment-697059170


   > Same question for me, should we remove one? or change the code from:
   > 
   > ```
   > #define IFF_DOWN           (1 << 0) /* Interface is down */
   > #define IFF_UP             (1 << 1) /* Interface is up */
   > ```
   > 
   > to:
   > 
   > ```
   > #define IFF_DOWN           (0 << 1) /* Interface is down */
   > #define IFF_UP             (1 << 1) /* Interface is up */
   > ```
   
   @xiaoxiang781216 
   
   I think that the above change does not work.
   So I think we should replace all IFF_DOWN related code both in nuttx and in apps with IFF_UP.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org