You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/09/24 02:29:53 UTC
Review Request 25970: Adding support for retryable storage errors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/
-----------------------------------------------------------
Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
Bugs: AURORA-187
https://issues.apache.org/jira/browse/AURORA-187
Repository: aurora
Description
-------
Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
Diff: https://reviews.apache.org/r/25970/diff/
Testing
-------
gradle -Pq build
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91
> > <https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91>
> >
> > minor nit I think the proper spelling is RETRIABLE
>
> Maxim Khutornenko wrote:
> Happy to change it. Neither appears to be a valid word though.
>
> Bill Farner wrote:
> ERROR_TRANSIENT?
>
> Brian Wickman wrote:
> True. I was going by http://en.wiktionary.org/wiki/retriable but the number of google hits for retryable is higher. English is hard, let's go computering.
Sigh...
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54557
-----------------------------------------------------------
On Sept. 25, 2014, 6:16 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 6:16 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Brian Wickman <wi...@apache.org>.
> On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91
> > <https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91>
> >
> > minor nit I think the proper spelling is RETRIABLE
>
> Maxim Khutornenko wrote:
> Happy to change it. Neither appears to be a valid word though.
>
> Bill Farner wrote:
> ERROR_TRANSIENT?
True. I was going by http://en.wiktionary.org/wiki/retriable but the number of google hits for retryable is higher. English is hard, let's go computering.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54557
-----------------------------------------------------------
On Sept. 25, 2014, 6:16 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 6:16 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Bill Farner <wf...@apache.org>.
> On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91
> > <https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91>
> >
> > minor nit I think the proper spelling is RETRIABLE
>
> Maxim Khutornenko wrote:
> Happy to change it. Neither appears to be a valid word though.
ERROR_TRANSIENT?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54557
-----------------------------------------------------------
On Sept. 25, 2014, 6:16 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 6:16 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91
> > <https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91>
> >
> > minor nit I think the proper spelling is RETRIABLE
Happy to change it. Neither appears to be a valid word though.
> On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/api/scheduler_client.py, line 296
> > <https://reviews.apache.org/r/25970/diff/2/?file=704573#file704573line296>
> >
> > it seems weird to be adding a new instance of a deprecated feature. can we switch it to use the new results API?
Sure, done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54557
-----------------------------------------------------------
On Sept. 24, 2014, 5:41 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 5:41 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54557
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java
<https://reviews.apache.org/r/25970/#comment94742>
minor nit I think the proper spelling is RETRIABLE
src/main/python/apache/aurora/client/api/scheduler_client.py
<https://reviews.apache.org/r/25970/#comment94743>
it seems weird to be adding a new instance of a deprecated feature. can we switch it to use the new results API?
- Brian Wickman
On Sept. 24, 2014, 5:41 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 5:41 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54440
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Sept. 24, 2014, 5:41 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 5:41 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54573
-----------------------------------------------------------
src/test/python/apache/aurora/client/api/test_scheduler_client.py
<https://reviews.apache.org/r/25970/#comment94757>
Isn't this not needed if you're specifying a side_effect?
- Joe Smith
On Sept. 25, 2014, 11:34 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 11:34 a.m.)
>
>
> Review request for Aurora, Bill Farner and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/
-----------------------------------------------------------
(Updated Sept. 25, 2014, 6:34 p.m.)
Review request for Aurora, Bill Farner and Brian Wickman.
Changes
-------
-mark as he is out today
Bugs: AURORA-187
https://issues.apache.org/jira/browse/AURORA-187
Repository: aurora
Description
-------
Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
Diff: https://reviews.apache.org/r/25970/diff/
Testing
-------
gradle -Pq build
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/
-----------------------------------------------------------
(Updated Sept. 25, 2014, 6:26 p.m.)
Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
Changes
-------
CR comments.
Bugs: AURORA-187
https://issues.apache.org/jira/browse/AURORA-187
Repository: aurora
Description
-------
Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
Diff: https://reviews.apache.org/r/25970/diff/
Testing
-------
gradle -Pq build
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54569
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On Sept. 25, 2014, 6:16 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2014, 6:16 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/
-----------------------------------------------------------
(Updated Sept. 25, 2014, 6:16 p.m.)
Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
Changes
-------
CR comments.
Bugs: AURORA-187
https://issues.apache.org/jira/browse/AURORA-187
Repository: aurora
Description
-------
Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
Diff: https://reviews.apache.org/r/25970/diff/
Testing
-------
gradle -Pq build
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/
-----------------------------------------------------------
(Updated Sept. 24, 2014, 5:41 p.m.)
Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
Changes
-------
CR comments.
Bugs: AURORA-187
https://issues.apache.org/jira/browse/AURORA-187
Repository: aurora
Description
-------
Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
Diff: https://reviews.apache.org/r/25970/diff/
Testing
-------
gradle -Pq build
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 24, 2014, 4:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java, line 82
> > <https://reviews.apache.org/r/25970/diff/1/?file=703526#file703526line82>
> >
> > Is there a downside if we always throw the more specific StorageException, rather than in these few cases?
>
> Maxim Khutornenko wrote:
> Not sure I understand. Are you suggesting altering a StorageException with something like isRetryable flag instead? Otherwise, we would not be able to differentiate between truly retryable cases like these ones from something like failed SQL insert/select.
>
> Bill Farner wrote:
> Nope i'm saying why should this class have retryIfNotInReadyState() throwing RetryableStorageException _and_ checkInState() throwing StorageException?
>
> i.e. can this diff just change checkInState to throw RetryableStorageException?
Ah, I see. Sure, even though other places may not be actionable it does not hurt to throw a more specific one instead. Changed.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54424
-----------------------------------------------------------
On Sept. 24, 2014, 12:29 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 12:29 a.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Bill Farner <wf...@apache.org>.
> On Sept. 24, 2014, 4:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java, line 82
> > <https://reviews.apache.org/r/25970/diff/1/?file=703526#file703526line82>
> >
> > Is there a downside if we always throw the more specific StorageException, rather than in these few cases?
>
> Maxim Khutornenko wrote:
> Not sure I understand. Are you suggesting altering a StorageException with something like isRetryable flag instead? Otherwise, we would not be able to differentiate between truly retryable cases like these ones from something like failed SQL insert/select.
Nope i'm saying why should this class have retryIfNotInReadyState() throwing RetryableStorageException _and_ checkInState() throwing StorageException?
i.e. can this diff just change checkInState to throw RetryableStorageException?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54424
-----------------------------------------------------------
On Sept. 24, 2014, 12:29 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 12:29 a.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 24, 2014, 4:58 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java, line 82
> > <https://reviews.apache.org/r/25970/diff/1/?file=703526#file703526line82>
> >
> > Is there a downside if we always throw the more specific StorageException, rather than in these few cases?
Not sure I understand. Are you suggesting altering a StorageException with something like isRetryable flag instead? Otherwise, we would not be able to differentiate between truly retryable cases like these ones from something like failed SQL insert/select.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54424
-----------------------------------------------------------
On Sept. 24, 2014, 12:29 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 12:29 a.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25970: Adding support for retryable storage errors.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25970/#review54424
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
<https://reviews.apache.org/r/25970/#comment94556>
Is there a downside if we always throw the more specific StorageException, rather than in these few cases?
- Bill Farner
On Sept. 24, 2014, 12:29 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25970/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 12:29 a.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman.
>
>
> Bugs: AURORA-187
> https://issues.apache.org/jira/browse/AURORA-187
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f
> src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f
> src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e
> src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282
>
> Diff: https://reviews.apache.org/r/25970/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>