You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/13 18:57:38 UTC

[GitHub] [arrow] coryan opened a new pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

coryan opened a new pull request #11406:
URL: https://github.com/apache/arrow/pull/11406


   Avoid using the default credentials for the unit test. In some
   environments these can be very slow to initialize, as they test several
   different potential sources of credentials, some including HTTP
   requests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] coryan commented on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
coryan commented on pull request #11406:
URL: https://github.com/apache/arrow/pull/11406#issuecomment-952360673


   Ping.  Is there are reason we cannot merge this PR?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] coryan commented on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
coryan commented on pull request #11406:
URL: https://github.com/apache/arrow/pull/11406#issuecomment-944561421


   > (1.5s make still be a bit long once there are a lot of tests, but perhaps it's not really possible to make it faster)
   
   I will see what I tolerate.  At some point I might start the testbench once, and then isolate the tests using different buckets or something similar.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11406:
URL: https://github.com/apache/arrow/pull/11406#issuecomment-952410227


   Benchmark runs are scheduled for baseline = 1bac50527ed3de83dbf6559caccf94b838305d8f and contender = 1b7178d47f4c117a6dba4c8da1733bba31287127. 1b7178d47f4c117a6dba4c8da1733bba31287127 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e5ad16a9dcac448e9cd7bac90cf5c8b7...b5fdf1e76dc0461b93d48465d8f5a79d/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/669e7e498eed401cb97b937591b67fe4...9e48675956ca4368836e9444ab91edf8/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/46662cc0f22b4c20adff7620761d35e4...8d19ce80a7dd45ed917ba3f759a44a70/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot commented on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11406:
URL: https://github.com/apache/arrow/pull/11406#issuecomment-952410227


   Benchmark runs are scheduled for baseline = 1bac50527ed3de83dbf6559caccf94b838305d8f and contender = 1b7178d47f4c117a6dba4c8da1733bba31287127. 1b7178d47f4c117a6dba4c8da1733bba31287127 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e5ad16a9dcac448e9cd7bac90cf5c8b7...b5fdf1e76dc0461b93d48465d8f5a79d/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/669e7e498eed401cb97b937591b67fe4...9e48675956ca4368836e9444ab91edf8/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/46662cc0f22b4c20adff7620761d35e4...8d19ce80a7dd45ed917ba3f759a44a70/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pitrou commented on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11406:
URL: https://github.com/apache/arrow/pull/11406#issuecomment-952673007


   @coryan  Sorry for the delay. I was on holiday.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11406:
URL: https://github.com/apache/arrow/pull/11406#issuecomment-942601083


   https://issues.apache.org/jira/browse/ARROW-14311


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] coryan commented on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
coryan commented on pull request #11406:
URL: https://github.com/apache/arrow/pull/11406#issuecomment-942631731


   @pitrou would you be able to test this in your environment?  I have good reason to believe (`strace` output) that this fixes the problem. An independent check would be helpful, as it was working well in my environment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] pitrou commented on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #11406:
URL: https://github.com/apache/arrow/pull/11406#issuecomment-944555037






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] coryan commented on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
coryan commented on pull request #11406:
URL: https://github.com/apache/arrow/pull/11406#issuecomment-947965746


   Is there something else I need to do here or can we merge this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kou closed pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
kou closed pull request #11406:
URL: https://github.com/apache/arrow/pull/11406


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11406:
URL: https://github.com/apache/arrow/pull/11406#issuecomment-952410227


   Benchmark runs are scheduled for baseline = 1bac50527ed3de83dbf6559caccf94b838305d8f and contender = 1b7178d47f4c117a6dba4c8da1733bba31287127. 1b7178d47f4c117a6dba4c8da1733bba31287127 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e5ad16a9dcac448e9cd7bac90cf5c8b7...b5fdf1e76dc0461b93d48465d8f5a79d/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/669e7e498eed401cb97b937591b67fe4...9e48675956ca4368836e9444ab91edf8/)
   [Finished :arrow_down:0.13% :arrow_up:0.18%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/46662cc0f22b4c20adff7620761d35e4...8d19ce80a7dd45ed917ba3f759a44a70/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ursabot edited a comment on pull request #11406: ARROW-14311: [C++] Make GCS FileSystem tests faster

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11406:
URL: https://github.com/apache/arrow/pull/11406#issuecomment-952410227


   Benchmark runs are scheduled for baseline = 1bac50527ed3de83dbf6559caccf94b838305d8f and contender = 1b7178d47f4c117a6dba4c8da1733bba31287127. 1b7178d47f4c117a6dba4c8da1733bba31287127 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e5ad16a9dcac448e9cd7bac90cf5c8b7...b5fdf1e76dc0461b93d48465d8f5a79d/)
   [Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/669e7e498eed401cb97b937591b67fe4...9e48675956ca4368836e9444ab91edf8/)
   [Finished :arrow_down:0.13% :arrow_up:0.18%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/46662cc0f22b4c20adff7620761d35e4...8d19ce80a7dd45ed917ba3f759a44a70/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org