You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ja...@apache.org on 2014/07/13 01:36:17 UTC
svn commit: r1610087 - in
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox:
pdmodel/graphics/color/PDColor.java rendering/PageDrawer.java
Author: jahewson
Date: Sat Jul 12 23:36:16 2014
New Revision: 1610087
URL: http://svn.apache.org/r1610087
Log:
PDFBOX-2205: clean up comments
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColor.java
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColor.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColor.java?rev=1610087&r1=1610086&r2=1610087&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColor.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/color/PDColor.java Sat Jul 12 23:36:16 2014
@@ -132,12 +132,14 @@ public final class PDColor
return patternName != null;
}
- // todo: toRGB() which returns a packed int
- // todo: getColorSpace() getter
-
- // STARTING POINT:
- // todo: JavaDoc [TODO: WHAT TO DO IF THIS IS A PATTERN? THROW ERROR?]
- public int toRGB(PDColorSpace colorSpace) throws IOException // todo: store colorSpace locally (Also, fallback color if exception?)
+ /**
+ * Returns the packed RGB value for this color, if any.
+ * @param colorSpace color space
+ * @return RGB
+ * @throws IOException
+ * @throws java.lang.IllegalStateException if this color value is a pattern.
+ */
+ public int toRGB(PDColorSpace colorSpace) throws IOException
{
float[] floats = colorSpace.toRGB(components);
int r = Math.round(floats[0] * 255);
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java?rev=1610087&r1=1610086&r2=1610087&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/rendering/PageDrawer.java Sat Jul 12 23:36:16 2014
@@ -261,7 +261,7 @@ public class PageDrawer extends PDFGraph
}
@Override
- public void processText(byte[] string) throws IOException
+ protected void processText(byte[] string) throws IOException
{
PDGraphicsState state = getGraphicsState();
Composite composite;
@@ -591,18 +591,7 @@ public class PageDrawer extends PDFGraph
return glyph2D;
}
- /**
- * Get the current line path to be drawn.
- *
- * @return The current line path to be drawn.
- */
- // TODO: NO LONGER PUBLIC :)
- /*public GeneralPath getLinePath()
- {
- return linePath;
- }*/
-
- @Override // todo: is this "append or draw?"
+ @Override
public void appendRectangle(Point2D p0, Point2D p1, Point2D p2, Point2D p3)
{
// to ensure that the path is created in the right direction, we have to create