You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/15 09:38:11 UTC

[GitHub] [cloudstack-primate] utchoang opened a new pull request #423: [FIX] Acquire public IP address does not give IP selection option

utchoang opened a new pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423


   Open for https://github.com/apache/cloudstack-primate/issues/392
   @rhtyd cc @svenvogel I've completed this task. Please review and let me know any comments.
   ![image](https://user-images.githubusercontent.com/13766648/84642361-8d274300-af26-11ea-9b13-654143152cec.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-645264517


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-645737223


   @rhtyd Sorry about this. I forgot to delete the test call function, so I called calling API twice. I've removed it. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-644583324


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/423 (JID-2011)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-645770787


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/423 (JID-2039)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-645265041


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-645764311


   @blueorangutan package
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-644576876


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-645288213


   @utchoang can you check why this call the API twice? In my testing, it was calling the API twice: (I've not reviewed code yet)
   ```
   zoneid: b6afade4-1919-4f0b-a785-12ff05a4d383
   domainid: e4874e10-5fdf-11ea-9a56-1e006800018c
   account: rohit
   forvirtualnetwork: true
   allocatedonly: false
   command: listPublicIpAddresses
   response: json
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
utchoang commented on a change in pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#discussion_r440694628



##########
File path: src/views/network/IpAddressesTab.vue
##########
@@ -181,6 +214,21 @@ export default {
         this.fetchLoading = false
       })
     },
+    fetchListPublicIpAddress () {
+      return new Promise((resolve, reject) => {
+        const params = {
+          zoneid: this.resource.zoneid,
+          domainid: this.resource.domainid,
+          account: this.resource.account,
+          forvirtualnetwork: true,
+          allocatedonly: false
+        }
+        api('listPublicIpAddresses', params).then(json => {
+          const listPublicIps = json.listpublicipaddressesresponse.publicipaddress || []
+          resolve(listPublicIps)

Review comment:
       @rhtyd I've fixed it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#discussion_r440684934



##########
File path: src/views/network/IpAddressesTab.vue
##########
@@ -181,6 +214,21 @@ export default {
         this.fetchLoading = false
       })
     },
+    fetchListPublicIpAddress () {
+      return new Promise((resolve, reject) => {
+        const params = {
+          zoneid: this.resource.zoneid,
+          domainid: this.resource.domainid,
+          account: this.resource.account,
+          forvirtualnetwork: true,
+          allocatedonly: false
+        }
+        api('listPublicIpAddresses', params).then(json => {
+          const listPublicIps = json.listpublicipaddressesresponse.publicipaddress || []
+          resolve(listPublicIps)

Review comment:
       Can you sort the IPs @utchoang (and make the list searching, like other a-selects)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-644576358


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-645764764


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #423: [FIX] Acquire public IP address does not give IP selection option

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #423:
URL: https://github.com/apache/cloudstack-primate/pull/423#issuecomment-645268741


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/423 (JID-2029)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org