You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Tommy Knowlton (JIRA)" <ji...@apache.org> on 2008/05/07 02:07:55 UTC
[jira] Created: (BUILDR-67) download(art =>
'http://example.com/foo?query') fails to send query part of URI when
performing the HTTP GET
download(art => 'http://example.com/foo?query') fails to send query part of URI when performing the HTTP GET
------------------------------------------------------------------------------------------------------------
Key: BUILDR-67
URL: https://issues.apache.org/jira/browse/BUILDR-67
Project: Buildr
Issue Type: Bug
Components: Core features
Affects Versions: 1.2.10
Reporter: Tommy Knowlton
This appears to be caused by inappropriate use of the URI's path member at the point where the GET is performed.
I have already tested a fix that works against 1.2.10 (released) code.
Also, looking at the trunk code, it appears that this bug remains, although the code affected in 1.2.10 has since been rewritten to use Net::HTTP (i.e., the rewrite still uses uri.path when uri.request_uri seems to be more correct).
I *have not* yet created a unit test to fail.
I'm not clear in my mind about the 'priority' on this, but I'm leaving it at 'Major' for now, because it breaks my organization's builds. I don't particularly care if the project management team sees fit to move the priority down on this.
I expect to submit one or more patches Real Soon Now (TM).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (BUILDR-67) download(art =>
'http://example.com/foo?query') fails to send query part of URI when
performing the HTTP GET
Posted by "Victor Hugo Borja (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Victor Hugo Borja resolved BUILDR-67.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.3.1
Yes, that's the way patches should be submitted (specs and impl on their own patches ready for `git am`), thanks Tommy.
For simple merges (two branches) I'd recommend using git rebase instead of git merge, so that commits just get fast-forwarded (retaining the commit messages).
> download(art => 'http://example.com/foo?query') fails to send query part of URI when performing the HTTP GET
> ------------------------------------------------------------------------------------------------------------
>
> Key: BUILDR-67
> URL: https://issues.apache.org/jira/browse/BUILDR-67
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.2.10
> Reporter: Tommy Knowlton
> Fix For: 1.3.1
>
> Attachments: 0001-Add-a-failing-spec-test-demonstrating-issue-BUILDR.patch, 0002-fix-for-BUILDR-67.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This appears to be caused by inappropriate use of the URI's path member at the point where the GET is performed.
> I have already tested a fix that works against 1.2.10 (released) code.
> Also, looking at the trunk code, it appears that this bug remains, although the code affected in 1.2.10 has since been rewritten to use Net::HTTP (i.e., the rewrite still uses uri.path when uri.request_uri seems to be more correct).
> I *have not* yet created a unit test to fail.
> I'm not clear in my mind about the 'priority' on this, but I'm leaving it at 'Major' for now, because it breaks my organization's builds. I don't particularly care if the project management team sees fit to move the priority down on this.
> I expect to submit one or more patches Real Soon Now (TM).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-67) download(art =>
'http://example.com/foo?query') fails to send query part of URI when
performing the HTTP GET
Posted by "Tommy Knowlton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tommy Knowlton updated BUILDR-67:
---------------------------------
Attachment: 0002-fix-for-BUILDR-67.patch
again, I will appreciate feedback on whether I've managed to use git effectively here.
In particular, why did 'git push' give me the error: fatal: The remote end hung up unexpectedly
?
> download(art => 'http://example.com/foo?query') fails to send query part of URI when performing the HTTP GET
> ------------------------------------------------------------------------------------------------------------
>
> Key: BUILDR-67
> URL: https://issues.apache.org/jira/browse/BUILDR-67
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.2.10
> Reporter: Tommy Knowlton
> Attachments: 0001-Add-a-failing-spec-test-demonstrating-issue-BUILDR.patch, 0002-fix-for-BUILDR-67.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This appears to be caused by inappropriate use of the URI's path member at the point where the GET is performed.
> I have already tested a fix that works against 1.2.10 (released) code.
> Also, looking at the trunk code, it appears that this bug remains, although the code affected in 1.2.10 has since been rewritten to use Net::HTTP (i.e., the rewrite still uses uri.path when uri.request_uri seems to be more correct).
> I *have not* yet created a unit test to fail.
> I'm not clear in my mind about the 'priority' on this, but I'm leaving it at 'Major' for now, because it breaks my organization's builds. I don't particularly care if the project management team sees fit to move the priority down on this.
> I expect to submit one or more patches Real Soon Now (TM).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-67) download(art =>
'http://example.com/foo?query') fails to send query part of URI when
performing the HTTP GET
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594961#action_12594961 ]
Assaf Arkin commented on BUILDR-67:
-----------------------------------
Will try git rebase next time. Hope you don't mind my experimenting, still learning as we go along.
> download(art => 'http://example.com/foo?query') fails to send query part of URI when performing the HTTP GET
> ------------------------------------------------------------------------------------------------------------
>
> Key: BUILDR-67
> URL: https://issues.apache.org/jira/browse/BUILDR-67
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.2.10
> Reporter: Tommy Knowlton
> Fix For: 1.3.1
>
> Attachments: 0001-Add-a-failing-spec-test-demonstrating-issue-BUILDR.patch, 0002-fix-for-BUILDR-67.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This appears to be caused by inappropriate use of the URI's path member at the point where the GET is performed.
> I have already tested a fix that works against 1.2.10 (released) code.
> Also, looking at the trunk code, it appears that this bug remains, although the code affected in 1.2.10 has since been rewritten to use Net::HTTP (i.e., the rewrite still uses uri.path when uri.request_uri seems to be more correct).
> I *have not* yet created a unit test to fail.
> I'm not clear in my mind about the 'priority' on this, but I'm leaving it at 'Major' for now, because it breaks my organization's builds. I don't particularly care if the project management team sees fit to move the priority down on this.
> I expect to submit one or more patches Real Soon Now (TM).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-67) download(art =>
'http://example.com/foo?query') fails to send query part of URI when
performing the HTTP GET
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594976#action_12594976 ]
Assaf Arkin commented on BUILDR-67:
-----------------------------------
That's right, that way we know it solved your problem.
> download(art => 'http://example.com/foo?query') fails to send query part of URI when performing the HTTP GET
> ------------------------------------------------------------------------------------------------------------
>
> Key: BUILDR-67
> URL: https://issues.apache.org/jira/browse/BUILDR-67
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.2.10
> Reporter: Tommy Knowlton
> Fix For: 1.3.1
>
> Attachments: 0001-Add-a-failing-spec-test-demonstrating-issue-BUILDR.patch, 0002-fix-for-BUILDR-67.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This appears to be caused by inappropriate use of the URI's path member at the point where the GET is performed.
> I have already tested a fix that works against 1.2.10 (released) code.
> Also, looking at the trunk code, it appears that this bug remains, although the code affected in 1.2.10 has since been rewritten to use Net::HTTP (i.e., the rewrite still uses uri.path when uri.request_uri seems to be more correct).
> I *have not* yet created a unit test to fail.
> I'm not clear in my mind about the 'priority' on this, but I'm leaving it at 'Major' for now, because it breaks my organization's builds. I don't particularly care if the project management team sees fit to move the priority down on this.
> I expect to submit one or more patches Real Soon Now (TM).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (BUILDR-67) download(art =>
'http://example.com/foo?query') fails to send query part of URI when
performing the HTTP GET
Posted by "Tommy Knowlton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tommy Knowlton updated BUILDR-67:
---------------------------------
Attachment: 0001-Add-a-failing-spec-test-demonstrating-issue-BUILDR.patch
still trying to figure out whether I'm using git correctly; will a committer please email me with feedback whether this is right or wrong?
> download(art => 'http://example.com/foo?query') fails to send query part of URI when performing the HTTP GET
> ------------------------------------------------------------------------------------------------------------
>
> Key: BUILDR-67
> URL: https://issues.apache.org/jira/browse/BUILDR-67
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.2.10
> Reporter: Tommy Knowlton
> Attachments: 0001-Add-a-failing-spec-test-demonstrating-issue-BUILDR.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This appears to be caused by inappropriate use of the URI's path member at the point where the GET is performed.
> I have already tested a fix that works against 1.2.10 (released) code.
> Also, looking at the trunk code, it appears that this bug remains, although the code affected in 1.2.10 has since been rewritten to use Net::HTTP (i.e., the rewrite still uses uri.path when uri.request_uri seems to be more correct).
> I *have not* yet created a unit test to fail.
> I'm not clear in my mind about the 'priority' on this, but I'm leaving it at 'Major' for now, because it breaks my organization's builds. I don't particularly care if the project management team sees fit to move the priority down on this.
> I expect to submit one or more patches Real Soon Now (TM).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-67) download(art =>
'http://example.com/foo?query') fails to send query part of URI when
performing the HTTP GET
Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594948#action_12594948 ]
Assaf Arkin commented on BUILDR-67:
-----------------------------------
That was the right thing to do. On my side, I applied the first patch (git am), ran the tests (failed), applied the second patch, ran again (pass). At that point I had the patch committed locally, basically the same commit log that you have on your machine (including the same commit message).
The commit messages didn't transfer to SVN, I did something wrong, still trying to figure it out. But that's the correct way to send patches.
You can't git push directly because we still need to apply those patches manually, but (when I get the second part figured out), it would have had the same effect.
> download(art => 'http://example.com/foo?query') fails to send query part of URI when performing the HTTP GET
> ------------------------------------------------------------------------------------------------------------
>
> Key: BUILDR-67
> URL: https://issues.apache.org/jira/browse/BUILDR-67
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.2.10
> Reporter: Tommy Knowlton
> Attachments: 0001-Add-a-failing-spec-test-demonstrating-issue-BUILDR.patch, 0002-fix-for-BUILDR-67.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This appears to be caused by inappropriate use of the URI's path member at the point where the GET is performed.
> I have already tested a fix that works against 1.2.10 (released) code.
> Also, looking at the trunk code, it appears that this bug remains, although the code affected in 1.2.10 has since been rewritten to use Net::HTTP (i.e., the rewrite still uses uri.path when uri.request_uri seems to be more correct).
> I *have not* yet created a unit test to fail.
> I'm not clear in my mind about the 'priority' on this, but I'm leaving it at 'Major' for now, because it breaks my organization's builds. I don't particularly care if the project management team sees fit to move the priority down on this.
> I expect to submit one or more patches Real Soon Now (TM).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (BUILDR-67) download(art =>
'http://example.com/foo?query') fails to send query part of URI when
performing the HTTP GET
Posted by "Tommy Knowlton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tommy Knowlton closed BUILDR-67.
--------------------------------
I'm assuming that as the 'reporter' I am also expected to close the issue once I see it resolved.
If that is incorrect workflow, I hope to be told what the correct workflow would be.
I've enjoyed learning how to contribute to this project, thanks for providing the git mirror.
> download(art => 'http://example.com/foo?query') fails to send query part of URI when performing the HTTP GET
> ------------------------------------------------------------------------------------------------------------
>
> Key: BUILDR-67
> URL: https://issues.apache.org/jira/browse/BUILDR-67
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.2.10
> Reporter: Tommy Knowlton
> Fix For: 1.3.1
>
> Attachments: 0001-Add-a-failing-spec-test-demonstrating-issue-BUILDR.patch, 0002-fix-for-BUILDR-67.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This appears to be caused by inappropriate use of the URI's path member at the point where the GET is performed.
> I have already tested a fix that works against 1.2.10 (released) code.
> Also, looking at the trunk code, it appears that this bug remains, although the code affected in 1.2.10 has since been rewritten to use Net::HTTP (i.e., the rewrite still uses uri.path when uri.request_uri seems to be more correct).
> I *have not* yet created a unit test to fail.
> I'm not clear in my mind about the 'priority' on this, but I'm leaving it at 'Major' for now, because it breaks my organization's builds. I don't particularly care if the project management team sees fit to move the priority down on this.
> I expect to submit one or more patches Real Soon Now (TM).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-67) download(art =>
'http://example.com/foo?query') fails to send query part of URI when
performing the HTTP GET
Posted by "Tommy Knowlton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594802#action_12594802 ]
Tommy Knowlton commented on BUILDR-67:
--------------------------------------
OK, sorry for spamming the comment log here, call me a n00b. It isn't reflected here, but the comments were added at the time of each respective attachment.
> download(art => 'http://example.com/foo?query') fails to send query part of URI when performing the HTTP GET
> ------------------------------------------------------------------------------------------------------------
>
> Key: BUILDR-67
> URL: https://issues.apache.org/jira/browse/BUILDR-67
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.2.10
> Reporter: Tommy Knowlton
> Attachments: 0001-Add-a-failing-spec-test-demonstrating-issue-BUILDR.patch, 0002-fix-for-BUILDR-67.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This appears to be caused by inappropriate use of the URI's path member at the point where the GET is performed.
> I have already tested a fix that works against 1.2.10 (released) code.
> Also, looking at the trunk code, it appears that this bug remains, although the code affected in 1.2.10 has since been rewritten to use Net::HTTP (i.e., the rewrite still uses uri.path when uri.request_uri seems to be more correct).
> I *have not* yet created a unit test to fail.
> I'm not clear in my mind about the 'priority' on this, but I'm leaving it at 'Major' for now, because it breaks my organization's builds. I don't particularly care if the project management team sees fit to move the priority down on this.
> I expect to submit one or more patches Real Soon Now (TM).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (BUILDR-67) download(art =>
'http://example.com/foo?query') fails to send query part of URI when
performing the HTTP GET
Posted by "Tommy Knowlton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BUILDR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594804#action_12594804 ]
Tommy Knowlton commented on BUILDR-67:
--------------------------------------
one more item, the 'affects' version was marked as 1.2.10, but the 0001 and 0002 patches I've attached apply against HEAD, not against that branch.
Having said, if a committer wants to apply the change to the 1.2.x branch, the fix is the same: use request_uri attribute instead of path at the point where the HTTP GET is done. Maybe I'm too lazy to go figure out how to use git / svn to go back to that point in time in order to supply the appropriate patch, when it's like one word change, as described above. HTH!
> download(art => 'http://example.com/foo?query') fails to send query part of URI when performing the HTTP GET
> ------------------------------------------------------------------------------------------------------------
>
> Key: BUILDR-67
> URL: https://issues.apache.org/jira/browse/BUILDR-67
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.2.10
> Reporter: Tommy Knowlton
> Attachments: 0001-Add-a-failing-spec-test-demonstrating-issue-BUILDR.patch, 0002-fix-for-BUILDR-67.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This appears to be caused by inappropriate use of the URI's path member at the point where the GET is performed.
> I have already tested a fix that works against 1.2.10 (released) code.
> Also, looking at the trunk code, it appears that this bug remains, although the code affected in 1.2.10 has since been rewritten to use Net::HTTP (i.e., the rewrite still uses uri.path when uri.request_uri seems to be more correct).
> I *have not* yet created a unit test to fail.
> I'm not clear in my mind about the 'priority' on this, but I'm leaving it at 'Major' for now, because it breaks my organization's builds. I don't particularly care if the project management team sees fit to move the priority down on this.
> I expect to submit one or more patches Real Soon Now (TM).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.