You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ta...@apache.org on 2021/02/16 17:15:53 UTC
[tika] branch main updated: improve lyrics handling
This is an automated email from the ASF dual-hosted git repository.
tallison pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git
The following commit(s) were added to refs/heads/main by this push:
new a5f6051 improve lyrics handling
a5f6051 is described below
commit a5f6051e1f8190a2da31a06ce4322c2fea9c8845
Author: tballison <ta...@apache.org>
AuthorDate: Tue Feb 16 12:15:42 2021 -0500
improve lyrics handling
---
.../src/main/java/org/apache/tika/parser/mp3/LyricsHandler.java | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tika-parsers/tika-parsers-classic/tika-parsers-classic-modules/tika-parser-audiovideo-module/src/main/java/org/apache/tika/parser/mp3/LyricsHandler.java b/tika-parsers/tika-parsers-classic/tika-parsers-classic-modules/tika-parser-audiovideo-module/src/main/java/org/apache/tika/parser/mp3/LyricsHandler.java
index 12d0f2d..cc8f6b6 100644
--- a/tika-parsers/tika-parsers-classic/tika-parsers-classic-modules/tika-parser-audiovideo-module/src/main/java/org/apache/tika/parser/mp3/LyricsHandler.java
+++ b/tika-parsers/tika-parsers-classic/tika-parsers-classic-modules/tika-parser-audiovideo-module/src/main/java/org/apache/tika/parser/mp3/LyricsHandler.java
@@ -100,6 +100,10 @@ public class LyricsHandler {
int tagLen = Integer.parseInt(
lyrics.substring(pos+3, pos+8)
);
+ if (tagLen < 1 || tagLen > lyrics.length()) {
+ //something went wrong
+ break;
+ }
int startPos = pos + 8;
int endPos = startPos + tagLen;