[jira] [Commented] (AVRO-3618) [Java] TestBinaryDecoder should check consistency with directBinaryDecoder

["Christophe Le Saec (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-3618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597073#comment-17597073 ] 

Christophe Le Saec commented on AVRO-3618:
------------------------------------------

Hi Ryan,
Here small updates on unit test to use newDecoder function ({_}and so, DirectBinaryDecoder{_}) in unit test before conversion in JUnit5 with AVRO-3579.
 

> [Java] TestBinaryDecoder should check consistency with directBinaryDecoder
> --------------------------------------------------------------------------
>
>                 Key: AVRO-3618
>                 URL: https://issues.apache.org/jira/browse/AVRO-3618
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Ryan Skraba
>            Assignee: Christophe Le Saec
>            Priority: Major
>              Labels: starter
>             Fix For: 1.12.0
>
>
> The unit tests for TestBinaryDecoder were originally parameterized so that _every_ test verifies that {{*BinaryDecoder*}} and {{*DirectBinaryDecoder*}} show the same behaviour.
> In the meantime, some tests have been added or modified that only test BinaryDecoder (twice).  Where possible, this should be fixed so that both classes are checked and that their behaviour are the same.
> Notably: the {{testNegativeBytesLength}} throws a different exception when DirectBinaryEncoder is used.
> Please pay special attention around the tests deserializing invalid binary data: this might be an unrecoverable error for Avro that throws a runtime exception but shouldn't consume unnecessary resources or cause OutOfMemoryErrors.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)