You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "wangyinsheng (via GitHub)" <gi...@apache.org> on 2023/03/26 07:15:04 UTC
[GitHub] [iceberg] wangyinsheng opened a new pull request, #7209: Build: Remove services files introduced by third-party jars
wangyinsheng opened a new pull request, #7209:
URL: https://github.com/apache/iceberg/pull/7209
All the runtime project has relocated the third-party jars, but the service files has not relocated. If user's application use a service loader to load any service in the shadowed jar, it will find a service file but with the origin class name , that will cause `ClassNotFoundException`
The class name in the service file will be relocated too if add `mergeServiceFiles` in the `shadowJar` script. But I think the reason why we use `relocate` is avoid conflict with user's application, therefor I just remove all service files of third-party jars
In the spark and flink project, we has provided some service file for register data source, I can't find an easy way to exculde all service file of third-pary but keep the one we provided, I just exclude one by one. Maybe there is an easy way to do this, thanks for any suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wangyinsheng commented on pull request #7209: Build: Remove services files introduced by third-party jars
Posted by "wangyinsheng (via GitHub)" <gi...@apache.org>.
wangyinsheng commented on PR #7209:
URL: https://github.com/apache/iceberg/pull/7209#issuecomment-1486057922
PTAL @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org