[GitHub] [nifi] exceptionfactory commented on a change in pull request #5409: NIFI-9235 - Improve PutHDFS documentation; conflict detection

[GitBox <gi...@apache.org>]

exceptionfactory commented on a change in pull request #5409:
URL: https://github.com/apache/nifi/pull/5409#discussion_r714078574



##########
File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java
##########
@@ -228,6 +232,20 @@ protected void preProcessConfiguration(final Configuration config, final Process
         FsPermission.setUMask(config, new FsPermission(dfsUmask));
     }
 
+    @Override
+    protected void preProcessFileSystem(final FileSystem fileSystem, final ProcessContext context) throws IOException {
+        if (fileSystem instanceof DistributedFileSystem) {
+            final Path dirPath = new Path(context.getProperty(DIRECTORY).getValue());

Review comment:
       The `Directory` property indicates support for FlowFile Expression Language, which means that `getProperty()` needs to call `evaluateAttributeExpressions(FlowFile)`.  Since the FlowFile is not available in this method, it looks like a different approach is necessary.
   
   One option is implementing this hook through a method called from `onTrigger()`, but that would log a warning for every invocation of the Processor.
   
   Since the only current purpose of this hook is to log a warning, this may not be the best approach to the issue. Perhaps adding a note to the umask property would be a better option?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org