You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/10 01:41:33 UTC

[GitHub] [commons-compress] PeterAlfredLee opened a new pull request #165: OMPRESS-565 : add BufferPool support in zstd

PeterAlfredLee opened a new pull request #165:
URL: https://github.com/apache/commons-compress/pull/165


   Add `BufferPool` as a configuration in `ZstdCompressorInputStream`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #165: OMPRESS-565 : add BufferPool support in zstd

Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on pull request #165:
URL: https://github.com/apache/commons-compress/pull/165#issuecomment-776388961


   > How might we support the CompressorStreamFactory.createCompressorInputStream(InputStream) use case?
   
   -1. We do not support detailed configurations in `CompressorStreamFactory`. It's a simple input stream factory with compressor type detectors. I think we should keep it simple enough.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] PeterAlfredLee commented on pull request #165: OMPRESS-565 : add BufferPool support in zstd

Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on pull request #165:
URL: https://github.com/apache/commons-compress/pull/165#issuecomment-776387192


   > See also #163
   
   I can't see much differences between 1.4.8-1 and 1.4.8-3 of `zstd-jni`. Besides that, 1.4.8-4 is on the way(released 2 days ago).
   I think we can leave the pom as it is.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] coveralls commented on pull request #165: OMPRESS-565 : add BufferPool support in zstd

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #165:
URL: https://github.com/apache/commons-compress/pull/165#issuecomment-776371703


   
   [![Coverage Status](https://coveralls.io/builds/37005912/badge)](https://coveralls.io/builds/37005912)
   
   Coverage increased (+0.003%) to 87.355% when pulling **bad3f68a7c6f7e0759ccbb0fc93c83d5860178ed on PeterAlfredLee:COMPRESS-564** into **fdeacdb6d9eefb24f5ff29cdb4561aebc8d5b9ae on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] heuermh commented on pull request #165: OMPRESS-565 : add BufferPool support in zstd

Posted by GitBox <gi...@apache.org>.
heuermh commented on pull request #165:
URL: https://github.com/apache/commons-compress/pull/165#issuecomment-776810498


   > > How might we support the CompressorStreamFactory.createCompressorInputStream(InputStream) use case?
   > 
   > -1. We do not support detailed configurations in `CompressorStreamFactory`. It's a simple input stream factory with compressor type detectors. I think we should keep it simple enough.
   
   Fair enough.  I can do the stream format check beforehand; I use `CompressorStreamFactory` as a fallback.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] PeterAlfredLee merged pull request #165: OMPRESS-565 : add BufferPool support in zstd

Posted by GitBox <gi...@apache.org>.
PeterAlfredLee merged pull request #165:
URL: https://github.com/apache/commons-compress/pull/165


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] heuermh commented on pull request #165: OMPRESS-565 : add BufferPool support in zstd

Posted by GitBox <gi...@apache.org>.
heuermh commented on pull request #165:
URL: https://github.com/apache/commons-compress/pull/165#issuecomment-776386206


   Thanks @PeterAlfredLee!
   
   This LGTM for the use case where callers are using the `ZstdCompressorInputStream` constructor directly.
   
   How might we support the [`CompressorStreamFactory.createCompressorInputStream(InputStream)`](
   http://commons.apache.org/proper/commons-compress/javadocs/api-release/org/apache/commons/compress/compressors/CompressorStreamFactory.html#createCompressorInputStream-java.io.InputStream-) use case?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-compress] heuermh commented on pull request #165: OMPRESS-565 : add BufferPool support in zstd

Posted by GitBox <gi...@apache.org>.
heuermh commented on pull request #165:
URL: https://github.com/apache/commons-compress/pull/165#issuecomment-776383709


   See also #163


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org