[GitHub] mbeckerle commented on a change in pull request #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter
URL: https://github.com/apache/incubator-daffodil/pull/84#discussion_r204049977
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/dfa/Rules.scala
 ##########
 @@ -501,6 +503,11 @@ class EECStateBlock(states: => ArrayBuffer[State], blockEnd: DFADelimiter, val E
         r.nextState = StartState
       }
     },
+    Rule { (r: Registers) => couldBeFirstChar(r.data0, blockEnd) } {
+      (r: Registers) => {
+        r.status = StateKind.Paused //PTERMState
+      }
+    },
 
 Review comment:
   Can we add a test that we know drives these rules, so we can see if this data1 first thing is a bug? (I think it is.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services