You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/15 18:12:01 UTC
[GitHub] [spark] cloud-fan opened a new pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
cloud-fan opened a new pull request #31843:
URL: https://github.com/apache/spark/pull/31843
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This is a follow-up of https://github.com/apache/spark/pull/31808 and simplifies the implementation with one line (excluding comments).
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
code simplification
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-799699830
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136078/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-799658186
**[Test build #136078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136078/testReport)** for PR 31843 at commit [`52846d4`](https://github.com/apache/spark/commit/52846d4a3360435a90ab2957f68025df5432cc15).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-799699830
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136078/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-799658186
**[Test build #136078 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136078/testReport)** for PR 31843 at commit [`52846d4`](https://github.com/apache/spark/commit/52846d4a3360435a90ab2957f68025df5432cc15).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-799671597
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40661/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #31843: [SPARK-34749][SQL] Simplify ResolveCreateNamedStruct
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #31843:
URL: https://github.com/apache/spark/pull/31843
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-800897579
The scala 2.13 failure is unrelated. Can you take another look? @dongjoon-hyun @maropu , thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-800041040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-800962580
> The scala 2.13 failure is unrelated. Can you take another look? @dongjoon-hyun @maropu , thanks!
https://github.com/apache/spark/pull/31862 seems can fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-799675908
**[Test build #136078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136078/testReport)** for PR 31843 at commit [`52846d4`](https://github.com/apache/spark/commit/52846d4a3360435a90ab2957f68025df5432cc15).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31843: [SPARK-34749][SQL] Simplify ResolveCreateNamedStruct
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-801039866
Thanks! Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #31843: [SPARK-34749][SQL] Simplify ResolveCreateNamedStruct
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-801040580
The commit has a conflict with branch-3.1, so could you open a backport PR for the fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-799637669
cc @dongjoon-hyun @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-799682400
Could you fix the relevant UT failure?
```
[info] - dereference *** FAILED *** (335 milliseconds)
[info] == FAIL: Plans do not match ===
[info] !'Filter struct(a, 'a, b, 'b)[b] 'Filter named_struct(NamePlaceholder, 'a, NamePlaceholder, 'b)[b]
[info] +- OneRowRelation +- OneRowRelation (PlanTest.scala:161)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-799671597
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40661/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #31843:
URL: https://github.com/apache/spark/pull/31843#discussion_r595948276
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -339,6 +339,14 @@ object CreateStruct {
*/
def apply(children: Seq[Expression]): CreateNamedStruct = {
CreateNamedStruct(children.zipWithIndex.flatMap {
+ // For multi-part column name like `struct(a.b.c)`, it may be resolved into:
+ // 1. Attribute if `a.b.c` is simply a qualified column name.
+ // 2. GetStructField if `a.b` refers to a struct-type column.
+ // 3. GetArrayStructFields if `a.b` refers to a array-of-struct-type column.
+ // 4. GetMapValue if `a.b` refers to a map-type column.
+ // We should always use the last part of the column name (`c` in the above example) as the
+ // alias name inside CreateNamedStruct.
+ case (u: UnresolvedAttribute, _) => Seq(Literal(u.nameParts.last), u)
Review comment:
Ah, I see. This change makes `ResolveCreateNamedStruct` simpler. The fix seems smart.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-800042230
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136101/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31843: [SPARK-34749][SQL] Simplify CreateNamedStruct
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-800041040
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40683/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu edited a comment on pull request #31843: [SPARK-34749][SQL] Simplify ResolveCreateNamedStruct
Posted by GitBox <gi...@apache.org>.
maropu edited a comment on pull request #31843:
URL: https://github.com/apache/spark/pull/31843#issuecomment-801040580
The commit has a conflict with branch-3.1. Is it better to merge this in branch-3.1, too, because this is a follow-up of #31808? If so, could you open a backport PR for the fix?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org