[GitHub] [nifi] exceptionfactory opened a new pull request #5577: NIFI-9448 Improve S2S HTTP Extend Transaction Exception Handling

[GitBox <gi...@apache.org>]

exceptionfactory opened a new pull request #5577:
URL: https://github.com/apache/nifi/pull/5577


   #### Description of PR
   
   NIFI-9448 Improves Site-to-Site HTTP client processing for extend transaction exception handling.
   
   As part of sending or receive files over an HTTP S2S connection, the `SiteToSiteRestApiClient` starts a background command to request extension of the current transaction on a periodic basis. In situations when the underlying HTTP connection pool throws an `IllegalStateException`, the background command attempts to close the parent `SiteToSiteRestApiClient`. This behavior short-circuits potential retry attempts that might otherwise be allowed according to the configured timeout settings.
   
   These changes include refactoring the background command to a separate `ExtendTransactionCommand` class for easier testing. With the main `SiteToSiteRestApiClient` already wrapping an Apache HttpComponents `HttpClient` instance and connection pool, the refactored `ExtendTransactionCommand` reuses the same client and connection pool as opposed to creating a new instance of `SiteToSiteRestApiClient`. Additional changes include a null check in `PeerSelector` to avoid a potential `NullPointerException` when the Peer Persistence property is not configured. This pull request also removes the `SiteToSiteClientIT` as it does not provide significant value beyond the existing unit tests.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
   
   - [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [X] Have you written or updated unit tests to verify your changes?
   - [X] Have you verified that the full build is successful on JDK 8?
   - [X] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #5577: NIFI-9448 Improve S2S HTTP Extend Transaction Exception Handling

[GitBox <gi...@apache.org>]

asfgit closed pull request #5577:
URL: https://github.com/apache/nifi/pull/5577


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org