[jira] [Commented] (ORC-69) Add batch option support in orc-contents and orc-scan tools.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360265#comment-15360265 ] 

ASF GitHub Bot commented on ORC-69:
-----------------------------------

Github user omalley commented on the issue:

    https://github.com/apache/orc/pull/38
  
    I buy that we may want to test the batch size for performance tests, but orc-scan is the important tool there since you don't really want to benchmark the conversion into JSON.
    
    With that in mind, I've made a variant of this patch that:
    * reverts the change to orc-contents
    * switches orc-scan to use getopt_long
    * adds some test infrastructure so that we can test the executables
    * adds tests of the nominal and off-nominal invocations of orc-scan.
    
    Please see my changes on https://github.com/omalley/orc/tree/orc-69


> Add batch option support in orc-contents and orc-scan tools. 
> -------------------------------------------------------------
>
>                 Key: ORC-69
>                 URL: https://issues.apache.org/jira/browse/ORC-69
>             Project: Orc
>          Issue Type: Improvement
>          Components: tools
>            Reporter: hongwu
>            Assignee: hongwu
>            Priority: Trivial
>
> The batchSize in FileScan.cc and FileContents.cc is hard coded with 1000. I add option named --batch to support input batchSize from command line.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)