You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/05/15 16:10:32 UTC
Review Request 67135: Added test to verify presence of nested
container termination status.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67135/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.
Bugs: MESOS-8736
https://issues.apache.org/jira/browse/MESOS-8736
Repository: mesos
Description
-------
This test verifies that both mesos and composing containerizers
maintain the contract described in the Containerizer API regarding
availability of a termination status for terminated nested containers.
Diffs
-----
src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d
Diff: https://reviews.apache.org/r/67135/diff/1/
Testing
-------
internal CI
Thanks,
Andrei Budnik
Re: Review Request 67135: Added test to verify presence of nested
container termination status.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67135/#review203567
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On May 16, 2018, 12:10 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67135/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 12:10 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-8736
> https://issues.apache.org/jira/browse/MESOS-8736
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that both mesos and composing containerizers
> maintain the contract described in the Containerizer API regarding
> availability of a termination status for terminated nested containers.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d
>
>
> Diff: https://reviews.apache.org/r/67135/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 67135: Added test to verify presence of nested
container termination status.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67135/#review203159
-----------------------------------------------------------
Patch looks great!
Reviews applied: [66668, 66670, 66671, 66817, 67128, 67130, 65505, 67135]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 15, 2018, 4:10 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67135/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 4:10 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-8736
> https://issues.apache.org/jira/browse/MESOS-8736
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that both mesos and composing containerizers
> maintain the contract described in the Containerizer API regarding
> availability of a termination status for terminated nested containers.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d
>
>
> Diff: https://reviews.apache.org/r/67135/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 67135: Added test to verify presence of nested
container termination status.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67135/#review203147
-----------------------------------------------------------
PASS: Mesos patch 67135 was successfully built and tested.
Reviews applied: `['66668', '66670', '66671', '66817', '67128', '67130', '65505', '67135']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67135
- Mesos Reviewbot Windows
On May 15, 2018, 4:10 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67135/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 4:10 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-8736
> https://issues.apache.org/jira/browse/MESOS-8736
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that both mesos and composing containerizers
> maintain the contract described in the Containerizer API regarding
> availability of a termination status for terminated nested containers.
>
>
> Diffs
> -----
>
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 661be81d6036113295876546f565264b843b704d
>
>
> Diff: https://reviews.apache.org/r/67135/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>