You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "mbaechler (via GitHub)" <gi...@apache.org> on 2023/02/02 22:11:25 UTC

[GitHub] [james-project] mbaechler opened a new pull request, #1420: Fix a leak in TextExtractor

mbaechler opened a new pull request, #1420:
URL: https://github.com/apache/james-project/pull/1420

   I propose a new contract to make sure `TextExtractor` implementations close the provided input streams.
   
   I only made it to work with Default implementation but I'm sure it can be extended to other implementations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] mbaechler merged pull request #1420: Fix a leak in TextExtractor

Posted by "mbaechler (via GitHub)" <gi...@apache.org>.
mbaechler merged PR #1420:
URL: https://github.com/apache/james-project/pull/1420


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a diff in pull request #1420: Fix a leak in TextExtractor

Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1420:
URL: https://github.com/apache/james-project/pull/1420#discussion_r1095256375


##########
mailbox/api/src/test/java/org/apache/james/mailbox/extractor/TextExtractorContract.java:
##########
@@ -0,0 +1,59 @@
+package org.apache.james.mailbox.extractor;

Review Comment:
   Missing license



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org