You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@solr.apache.org by Christos Malliaridis <c....@gmail.com> on 2024/09/16 09:56:09 UTC

Re: Introducing Gradle Version Catalogs

I've now revised the initial PR (https://github.com/apache/solr/pull/2646)
and created a clean PR with the changes and version conflict resolution.
See for that https://github.com/apache/solr/pull/2706. The new PR does not
include dependency updates like the initial PR.

Right now, the constraints hold information about the dependencies that
cause the version conflict, so that in the future developers may check the
constraints of the updated dependency for matching constraints and clean it
up if the constraint is no longer necessary. I tried to find an easier or
more automated way to properly maintain the constraints that have been
added, but I couldn't find a better one. So if you have any ideas how this
could be improved, please let me know.

>

Re: Introducing Gradle Version Catalogs

Posted by Jan Høydahl <ja...@cominvent.com>.
I propose we try dependabot first for the new main - benefit is we don't need to host it ourselves.
If version catalogs are not backported to 9x, perhaps we can re-purpose SolrBot to file PRs for branch_9_N?

Jan

> 14. nov. 2024 kl. 05:47 skrev Christos Malliaridis <ma...@apache.org>:
> 
> The current bot would require some configuration changes to get it running again, as renovate relies on palantirs plugin for updating lock files, and I believe it uses "gradlew --write-locks" to update the file. This would not work anymore.
> 
> The bot already runs a custom task for including "gradlew updateLicenses", so it should be possible to also include "gradlew writeLocks". I tried to run it with updated configs on a project clone, but failed to get it up and running (it fails to fork the project).
> 
> I reviewed debendabot as well and it seems quite easy to get it up and running. We will only have to add add a basic config file and a workflow for running the two tasks "gradlew writeLocks" and "gradlew updateLicenses", as these cannot be configured in dependabot from what I know.
> 
> I think dependabot comes with better GitHub integration and it would be worth considering a switch, as Jan proposed.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org


Re: Introducing Gradle Version Catalogs

Posted by Christos Malliaridis <ma...@apache.org>.
The current bot would require some configuration changes to get it running again, as renovate relies on palantirs plugin for updating lock files, and I believe it uses "gradlew --write-locks" to update the file. This would not work anymore.

The bot already runs a custom task for including "gradlew updateLicenses", so it should be possible to also include "gradlew writeLocks". I tried to run it with updated configs on a project clone, but failed to get it up and running (it fails to fork the project).

I reviewed debendabot as well and it seems quite easy to get it up and running. We will only have to add add a basic config file and a workflow for running the two tasks "gradlew writeLocks" and "gradlew updateLicenses", as these cannot be configured in dependabot from what I know.

I think dependabot comes with better GitHub integration and it would be worth considering a switch, as Jan proposed.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org


Re: Introducing Gradle Version Catalogs

Posted by Jan Høydahl <ja...@cominvent.com>.
We’ll need to modify what files renovatebot considers, right now it is only two files, after it will probably be several.

Another option is to switch to Dependabot, which did not support consistent-versions plugin, but do support version catalogs.

Jan

> On 13 Nov 2024, at 16:38, David Smiley <ds...@apache.org> wrote:
> 
> Thanks again for this modernization effort, Christos!  A lot of work,
> clearly.
> 
> Do you imagine the "Renovate" bot will need updates to work in this new
> world?  I suppose we shall deal with that when we get to the other side.
> 
>> On Wed, Nov 13, 2024 at 10:12 AM Christos Malliaridis <
>> malliaridis@apache.org> wrote:
>> 
>> This is the last call for SOLR-17406 /
>> https://github.com/apache/solr/pull/2706. All matters have been resolved
>> and the changes will be merged soon if there are no objections.
>> 
>> If you are having any open PRs that make any changes in gradle files, I'd
>> recommend to wait before merging. If you add dependencies in your PRs, you
>> will likely have to update to the new dependency management format that
>> uses references instead of strings. This would be a great opportunity to
>> review the updated documentation in practice.
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
>> For additional commands, e-mail: dev-help@solr.apache.org
>> 
>> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org


Re: Introducing Gradle Version Catalogs

Posted by David Smiley <ds...@apache.org>.
Thanks again for this modernization effort, Christos!  A lot of work,
clearly.

Do you imagine the "Renovate" bot will need updates to work in this new
world?  I suppose we shall deal with that when we get to the other side.

On Wed, Nov 13, 2024 at 10:12 AM Christos Malliaridis <
malliaridis@apache.org> wrote:

> This is the last call for SOLR-17406 /
> https://github.com/apache/solr/pull/2706. All matters have been resolved
> and the changes will be merged soon if there are no objections.
>
> If you are having any open PRs that make any changes in gradle files, I'd
> recommend to wait before merging. If you add dependencies in your PRs, you
> will likely have to update to the new dependency management format that
> uses references instead of strings. This would be a great opportunity to
> review the updated documentation in practice.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
> For additional commands, e-mail: dev-help@solr.apache.org
>
>

Re: Introducing Gradle Version Catalogs

Posted by Christos Malliaridis <ma...@apache.org>.
This is the last call for SOLR-17406 / https://github.com/apache/solr/pull/2706. All matters have been resolved and the changes will be merged soon if there are no objections.

If you are having any open PRs that make any changes in gradle files, I'd recommend to wait before merging. If you add dependencies in your PRs, you will likely have to update to the new dependency management format that uses references instead of strings. This would be a great opportunity to review the updated documentation in practice.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org


Re: Introducing Gradle Version Catalogs

Posted by Christos Malliaridis <ma...@apache.org>.
Bringing up this topic again as the PR https://github.com/apache/solr/pull/2706 is ready for another review round.

Since it changes the way dependencies are managed, it would be great if we can get more eyes on the PR before merging it.

This is also the last "blocker" of the POC for the new Admin UI.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@solr.apache.org
For additional commands, e-mail: dev-help@solr.apache.org


Re: Introducing Gradle Version Catalogs

Posted by Dawid Weiss <da...@gmail.com>.
Hi Christos,

I've now revised the initial PR (https://github.com/apache/solr/pull/2646)
> and created a clean PR with the changes and version conflict resolution.
> See for that https://github.com/apache/solr/pull/2706. The new PR does
> not include dependency updates like the initial PR.
>

Nice! I think it's a good start. Updates can come later, even one at a time.


> Right now, the constraints hold information about the dependencies that
> cause the version conflict, so that in the future developers may check the
> constraints of the updated dependency for matching constraints and clean it
> up if the constraint is no longer necessary. I tried to find an easier or
> more automated way to properly maintain the constraints that have been
> added, but I couldn't find a better one. So if you have any ideas how this
> could be improved, please let me know.
>

I think I mentioned this already but, sadly, I haven't found any more
"automated" way of managing these constraints along with version updates.
I'm sure one could try to craft something... but it's an
uncharted territory for me and it's never been a problem for me to just
review them manually.

Dawid