You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/10 14:40:53 UTC
[GitHub] [incubator-seatunnel] kalencaya opened a new pull request #1464: [Bug] [flink-connector-jdbc] change jdbc related dependency scope from provided to default scope
kalencaya opened a new pull request #1464:
URL: https://github.com/apache/incubator-seatunnel/pull/1464
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Fix #1463
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kalencaya commented on a change in pull request #1464: [Bug] [flink-connector-jdbc] change jdbc related dependency scope from provided to default scope
Posted by GitBox <gi...@apache.org>.
kalencaya commented on a change in pull request #1464:
URL: https://github.com/apache/incubator-seatunnel/pull/1464#discussion_r825622723
##########
File path: docs/en/flink/configuration/sink-plugins/Jdbc.md
##########
@@ -22,7 +22,9 @@ Write data through jdbc
### driver [string]
-Driver name, such as `com.mysql.jdbc.Driver`
+Driver name, such as `com.mysql.cj.jdbc.Driver`.
+
+Warn: for license compliance, you have to provide MySQL JDBC driver yourself.
Review comment:
Good advise, I'll add more guiding info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1464: [Bug] [flink-connector-jdbc] change jdbc related dependency scope from provided to default scope
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1464:
URL: https://github.com/apache/incubator-seatunnel/pull/1464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kalencaya commented on pull request #1464: [Bug] [flink-connector-jdbc] change jdbc related dependency scope from provided to default scope
Posted by GitBox <gi...@apache.org>.
kalencaya commented on pull request #1464:
URL: https://github.com/apache/incubator-seatunnel/pull/1464#issuecomment-1066469194
more PR intended for removing never used and outdated dependency for `flink-jdbc_${scala.binary.version}`, which is renamed to `flink-connector-jdbc_${scala.binary.version}` from Flink `1.11.0` version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on a change in pull request #1464: [Bug] [flink-connector-jdbc] change jdbc related dependency scope from provided to default scope
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #1464:
URL: https://github.com/apache/incubator-seatunnel/pull/1464#discussion_r825569940
##########
File path: docs/en/flink/configuration/sink-plugins/Jdbc.md
##########
@@ -22,7 +22,9 @@ Write data through jdbc
### driver [string]
-Driver name, such as `com.mysql.jdbc.Driver`
+Driver name, such as `com.mysql.cj.jdbc.Driver`.
+
+Warn: for license compliance, you have to provide MySQL JDBC driver yourself.
Review comment:
It might be better to describe how to add `mysql-connector-java`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org